You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Put a breakpoint in apps/files_encryption/hooks/hooks.php in the function login
Run curl -D - http://user:password@localhost/owncloud/
Run curl -D - http://user:password@localhost/owncloud/remote.php/webdav
Expected result
Both curl calls return a session cookie and both run the login hook.
Actual result
Basic auth on the root at step 2. does NOT call the login hook.
Result: if that session is used to upload files, encryption is disabled and files are not encrypted.
I'd expect the encryption library to throw an exception instead of just not encrypting files. CC @schiesbn (`shouldEncrypt() simply returns false when encryption was not initialized)
Note: this doesn't happen with the known WebDAV clients (sync client, dolphin, cadaver, etc) because they all authenticate directly against "remote.php/webdav".
But ownCloud aware libraries might do it like pyocclient and authenticate on the root, because the library might be used for OCS as well as for WebDAV.
I'll fix pyocclient for now to use the Webdav endpoint in the mean time.
Steps to reproduce:
apps/files_encryption/hooks/hooks.php
in the functionlogin
curl -D - http://user:password@localhost/owncloud/
curl -D - http://user:password@localhost/owncloud/remote.php/webdav
Expected result
Both curl calls return a session cookie and both run the login hook.
Actual result
Basic auth on the root at step 2. does NOT call the login hook.
Result: if that session is used to upload files, encryption is disabled and files are not encrypted.
I'd expect the encryption library to throw an exception instead of just not encrypting files. CC @schiesbn (`shouldEncrypt() simply returns false when encryption was not initialized)
Note: this doesn't happen with the known WebDAV clients (sync client, dolphin, cadaver, etc) because they all authenticate directly against "remote.php/webdav".
But ownCloud aware libraries might do it like
pyocclient
and authenticate on the root, because the library might be used for OCS as well as for WebDAV.I'll fix
pyocclient
for now to use the Webdav endpoint in the mean time.Versions
ownCloud 7.0.2
Apache 2.4
@LukasReschke @DeepDiver1975 @schiesbn
The text was updated successfully, but these errors were encountered: