Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI lostpassword.php is not calling warning message when encryption app is enabled #11438

Closed
gig13 opened this issue Oct 6, 2014 · 7 comments · Fixed by #11696
Closed
Assignees
Milestone

Comments

@gig13
Copy link

gig13 commented Oct 6, 2014

Expected behavior
When a user with encryption enabled goes to reset the password, the lostpassword.php file should be executed and the user is warned about the recovery key and losing all his/her data.

Actual behavior
The standard reset message is displayed, and the email notification message is displayed.

Steps to reproduce

  1. Install owncloud and enable encryption
  2. Setup personal information email and the recovery key
  3. Logout
  4. Attempt to login with an incorrect password

Server configuration
Ubuntu 14
MySql
OC7 beta2
Browser Firefox

@DeepDiver1975
Copy link
Member

@LukasReschke seems like this fits into the mail settings pr you are working on - right?

@LukasReschke
Copy link
Member

Mhm. This is again in another file but it can be fairly easily solved. Assigning to myself and trying to find some time end of the week.

That said: I still believe that the encryption app should use a per-instance key and not a per-user one. So many problems would go away…

@LukasReschke LukasReschke self-assigned this Oct 8, 2014
@schiessle
Copy link
Contributor

Just as a note: There was a warning on the old password reset page. It was removed because it was considered to be to alarming, if I remember correctly. Maybe it makes sense to include @jancborchardt into the discussion to make sure that we don't add, remove, add,... stuff and have one consistent opinion.

@jancborchardt
Copy link
Member

Sounds like a note is in order here when people are about to lose their data.

@etiess
Copy link

etiess commented Oct 20, 2014

I just experienced this confusion and I think a note is definitely necessary. This notification should be different in 2 cases:

  1. If the user doesn't have a recovery key, he is informed that reseting the password will lead to data loss on the server. The user should clearly accept that (box to check or link to click on) in order to reset the password.
  2. If the user has a recovery key, he is informed that reseting the password will allow him to access his account except his files (possible access to calendar, contacts, ...). And that he should contact the admin to recover full access.

My point is that a different message should be sent / displayed in each case. And that in case 2, he should be notified that he won't get access to his files without contacting the admin.

I was confused in #11661 and @schiesbn explained me this clearly (thank you ;) ). Once this notification is integrated, I can modifiy the documentation to explain this if you want.

And just to complete the information, @jancborchardt and @VicDeo are managing a modification in the password recovery process in #10353 . The objective is to integrate a:

  1. double-entry of the password to avoid typing error
  2. message indicating the reset was successful

Still, I think (and it's my opinion) that the password recovery should be possible by email. Why not with a 2-step verification process like in Gmail? I know it's difficult to integrate a verification with SMS, but the second step could be an email automatically sent to the admin. The admin can then decide to use the recovery key.

@craigpg craigpg added this to the 2014-sprint-06-current milestone Oct 20, 2014
LukasReschke added a commit that referenced this issue Oct 21, 2014
This patch wil warn the user of the consequences when resetting the password and requires checking a checkbox (as we had in the past) to reset a password.

Furthermore I updated the code to use our new classes and added some unit tests for it 👯

Fixes #11438
@craigpg craigpg modified the milestones: 2014-sprint-07-current, 2014-sprint-06 Oct 27, 2014
LukasReschke added a commit that referenced this issue Oct 29, 2014
This patch wil warn the user of the consequences when resetting the password and requires checking a checkbox (as we had in the past) to reset a password.

Furthermore I updated the code to use our new classes and added some unit tests for it 👯

Fixes #11438
@craigpg craigpg modified the milestones: 2014-sprint-08-current, 2014-sprint-07 Nov 10, 2014
LukasReschke added a commit that referenced this issue Nov 17, 2014
This patch wil warn the user of the consequences when resetting the password and requires checking a checkbox (as we had in the past) to reset a password.

Furthermore I updated the code to use our new classes and added some unit tests for it 👯

Fixes #11438
@butonic
Copy link
Member

butonic commented Nov 19, 2014

cc @owncloud/support-triagers

@LukasReschke
Copy link
Member

Will be fixed with ownCloud 8: #11696

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants