Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search field work in apps management page #11635

Closed
PVince81 opened this issue Oct 17, 2014 · 11 comments
Closed

Make search field work in apps management page #11635

PVince81 opened this issue Oct 17, 2014 · 11 comments
Labels
Milestone

Comments

@PVince81
Copy link
Contributor

Steps to reproduce:

  1. On master (0412f83) go to the apps management page.
  2. Type "encryption" in the search field

Expected result

The apps list only shows the encryption app

Actual result

Nothing happens

@owncloud/designers @DeepDiver1975

@jancborchardt
Copy link
Member

Well, we can't really use the global search field for that since it has a different use, and is an entirely different app.

As said before we need to move to in-app search much like the user management already does (ideally on the top left though), and eventually phase out the global search box. Cc @butonic

@PVince81
Copy link
Contributor Author

As long as the app list can quickly be filtered then it's fine, even if it means having a search field in the controls bar.

@enoch85
Copy link
Member

enoch85 commented Oct 19, 2014

The global search app works bad as it is. Generating a ton of errors in owncloud.log for instance.

@butonic
Copy link
Member

butonic commented Oct 20, 2014

@jancborchardt I am planning to work on that after the EE release. Might be good to have your input before that. Will update #821 when the time comes

@jancborchardt
Copy link
Member

@butonic great! Essentially we should go app-by-app and add a proper filtering search (like in Users management).

Probably wise to start with the Apps mgmt as a proof-of-concept, then move onto Files.

I’m thinking if we should do the placement on the top left as first item in the sidebar, or better just leave the search box as it is placed, but make it filter inline specific to the app instead of the current popup box. I tend towards the latter.

@butonic
Copy link
Member

butonic commented Oct 20, 2014

My idea was to replace 'search' with 'filter' in the current top right global search input field. I'd hide it by default and only show it in apps that register a search provider.

I'd like your opinion on a two step approach 'filter & find': typing in the search bar should filter the currently visible content (for files = filter the current folder). Pressing enter triggers a search in the current app (for files = find everywhere) maybe pressing enter a second time searches in file contents (via search lucene)?

Am 20. Oktober 2014 15:58:29 MESZ, schrieb Jan-Christoph Borchardt notifications@github.com:

@butonic great! Essentially we should go app-by-app and add a proper
filtering search (like in Users management).

Probably wise to start with the Apps mgmt as a proof-of-concept, then
move onto Files.

I’m thinking if we should do the placement on the top left as first
item in the sidebar, or better just leave the search box as it is
placed, but make it filter inline specific to the app instead of the
current popup box. I tend towards the latter.


Reply to this email directly or view it on GitHub:
#11635 (comment)

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

@jancborchardt
Copy link
Member

My idea was to replace 'search' with 'filter' in the current top right global search input field. I'd hide it by default and only show it in apps that register a search provider.

Sounds good!

I'd like your opinion on a two step approach 'filter & find': typing in the search bar should filter the currently visible content (for files = filter the current folder). Pressing enter triggers a search in the current app (for files = find everywhere) maybe pressing enter a second time searches in file contents (via search lucene)?

I would say that it should be search-as-you-type, so »filter« and »search« (current view vs searching in everything) should be the same. Of course the results in the current view should be prioritized.
But an approach where you have to press enter multiple times is something which is definitely going to confuse people.

@oparoz
Copy link
Contributor

oparoz commented Jan 27, 2015

I'd hide it by default and only show it in apps that register a search provider.

Still missing and confusing for users who expect to be able to get some form of results straight from the search field.

@butonic Any idea when this will land?

@DeepDiver1975
Copy link
Member

filtering the apps is currently being worked on - #13439 - scheduled for 8.1

@DeepDiver1975 DeepDiver1975 added this to the 8.1-next milestone Jan 27, 2015
@oparoz
Copy link
Contributor

oparoz commented Feb 25, 2015

@butonic - The search field is still not hidden by default. It's confusing for users to have non-working UI elements.

@jancborchardt
Copy link
Member

@oparoz can you actually open a new, more general issue? This specific one was solved (Search in apps management) and I’ll close this.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants