-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ownCloud should check for mbstring.func_overload #14372
Comments
#shit-php-does |
@RealRancor why is news in the modules array? This thing applies globally |
@RealRancor: Please add them there: Line 575 in 7a9d428
|
Sorry, i won't start doing core development. The checks in the linked app are easy for me to add and test on my stable7 productive system and the settings.php is also linked in a forums thread. If this should be added to core someone else needs to do it. |
@MorrisJobke new: mbstring.func_overload, output_buffering so its probably better that an more experienced dev is adding an general test for ini settings in the util.php |
Yes – fair point – will add an helper here as well. Thanks @RealRancor. |
This allows to check for specific values in the PHP.ini that ownCloud requires for full compatibility. `mbstring.func_overload`: #14372 `output_buffering`: http://doc.owncloud.org/server/8.0/admin_manual/configuration/big_file_upload_configuration.html#configuring-php Fixes #14372 and #14412
Linking issue owncloud-archive/news#732
mbstring.func_overload basically tells PHP to use mb functions instead of the default ones, e.g.: stlren is turned into mb_strlen
This can cause all sorts of shenanigans, like broken pages (https://github.com/owncloud/core/blob/master/lib/private/appframework/app.php#L116) etc.
We should therefore warn on admins on the admin and setup page if they've enabled this setting
@DeepDiver1975 @MorrisJobke @LukasReschke @PVince81
The text was updated successfully, but these errors were encountered: