Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ownCloud should check for mbstring.func_overload #14372

Closed
BernhardPosselt opened this issue Feb 19, 2015 · 6 comments · Fixed by #14414
Closed

ownCloud should check for mbstring.func_overload #14372

BernhardPosselt opened this issue Feb 19, 2015 · 6 comments · Fixed by #14414
Labels
Milestone

Comments

@BernhardPosselt
Copy link
Contributor

Linking issue owncloud-archive/news#732

mbstring.func_overload basically tells PHP to use mb functions instead of the default ones, e.g.: stlren is turned into mb_strlen

This can cause all sorts of shenanigans, like broken pages (https://github.com/owncloud/core/blob/master/lib/private/appframework/app.php#L116) etc.

We should therefore warn on admins on the admin and setup page if they've enabled this setting

@DeepDiver1975 @MorrisJobke @LukasReschke @PVince81

@BernhardPosselt
Copy link
Contributor Author

#shit-php-does

@BernhardPosselt
Copy link
Contributor Author

@RealRancor why is news in the modules array? This thing applies globally

@MorrisJobke
Copy link
Contributor

@RealRancor: Please add them there:

$dependencies = array(

@ghost
Copy link

ghost commented Feb 19, 2015

Sorry, i won't start doing core development.

The checks in the linked app are easy for me to add and test on my stable7 productive system and the settings.php is also linked in a forums thread.

If this should be added to core someone else needs to do it.

@ghost
Copy link

ghost commented Feb 21, 2015

@MorrisJobke
Btw. its now the third ini setting which should be checked in the util.php:

new: mbstring.func_overload, output_buffering
existing: default_charset

so its probably better that an more experienced dev is adding an general test for ini settings in the util.php

@LukasReschke
Copy link
Member

Yes – fair point – will add an helper here as well. Thanks @RealRancor.

LukasReschke added a commit that referenced this issue Feb 21, 2015
This allows to check for specific values in the PHP.ini that ownCloud requires for full compatibility.

`mbstring.func_overload`: #14372
`output_buffering`: http://doc.owncloud.org/server/8.0/admin_manual/configuration/big_file_upload_configuration.html#configuring-php

Fixes #14372 and #14412
@DeepDiver1975 DeepDiver1975 added this to the 8.0.1-next-maintenance milestone Feb 22, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants