Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix experimental tag for cloned and disabled apps #17003

Closed
LukasReschke opened this issue Jun 17, 2015 · 3 comments · Fixed by #17050
Closed

Fix experimental tag for cloned and disabled apps #17003

LukasReschke opened this issue Jun 17, 2015 · 3 comments · Fixed by #17050
Labels
3 - To Review settings:apps Type:Bug
Milestone
8.1

Comments

@LukasReschke
Copy link
Member

(do a lookup at server if ocsid is provided)
@LukasReschke LukasReschke added this to the 8.1-current milestone Jun 17, 2015
LukasReschke added a commit that referenced this issue Jun 19, 2015
@LukasReschke
Request approved state for disabled apps with ocsid
00a65e3 
In case an application gets disabled the level is set to "experimental" if it does not contain a `shipped` tag. This can for example be reproduced by installing the documents app from the appstore and then disabling it. Or cloning an app from git.

With this change the controller will now load the level of the application from the appstore if a valid OCSID has been provided.

Fixes #17003
@LukasReschke LukasReschke mentioned this issue Jun 19, 2015
Merged
@MorrisJobke
Copy link
Contributor

cc @nickvergessen @libasys

@MorrisJobke
Copy link
Contributor

@LukasReschke just mentioned that an app is labeled as "experimental" if it is not approved. Maybe we should rename this to "not approved". Because it is a huge difference

@LukasReschke
Copy link
Member Author

Just FTR: I'm fine with the experimental rating.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - To Review settings:apps Type:Bug
Projects
None yet
Milestone
8.1
Development

Successfully merging a pull request may close this issue.

Request approved state for disabled apps with ocsid owncloud/core
2 participants
@MorrisJobke @LukasReschke