Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap tooltip broke tipsy for app levels #17870

Closed
LukasReschke opened this issue Jul 25, 2015 · 3 comments · Fixed by #17871
Closed

bootstrap tooltip broke tipsy for app levels #17870

LukasReschke opened this issue Jul 25, 2015 · 3 comments · Fixed by #17871

Comments

@LukasReschke
Copy link
Member

Regression caused by #17075

@LukasReschke
Copy link
Member Author

Basically everything using fallback is broken, see

core/settings/js/apps.js

Lines 121 to 123 in 1e48eb8

$('.app-level .official').tipsy({fallback: t('settings', 'Official apps are developed by and within the ownCloud community. They offer functionality central to ownCloud and are ready for production use.')});
$('.app-level .approved').tipsy({fallback: t('settings', 'Approved apps are developed by trusted developers and have passed a cursory security check. They are actively maintained in an open code repository and their maintainers deem them to be stable for casual to normal use.')});
$('.app-level .experimental').tipsy({fallback: t('settings', 'This app is not checked for security issues and is new or known to be unstable. Install at your own risk.')});
for the affected code.

LukasReschke added a commit that referenced this issue Jul 25, 2015
Tipsy also supported the `fallback` element which will now not work anymore. To enhance compatibility we shall also implement it in the shim.

Fixes #17870
@LukasReschke
Copy link
Member Author

Proposed patch is at #17871

@davitol
Copy link
Contributor

davitol commented Aug 14, 2015

👍 Looks good

@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants