SSL connection doesn't happen when using login credentials with webdav external storage. #22016

SergioBertolinSG · 2016-01-29T12:36:41Z

Steps to reproduce

Enable external storage.
Mount webdav external storage using login credentials stored on database, using https.
Login using user which can access that server.
See files view.

Expected behaviour

Folder is correctly mounted.

Actual behaviour

Folder is not mounted.

Tested with accepted certificates and self-signed. Both fails to connect (But doesn't shows red square).

Server configuration

Operating system:
Ubuntu 14.04

Web server:
Apache

Database:
MySQL

PHP version:
5.5.9

ownCloud version: (see ownCloud admin page)
Master branch
{"installed":true,"maintenance":false,"version":"9.0.0.6","versionstring":"9.0 pre alpha","edition":""}

Updated from an older ownCloud or fresh install:
Fresh

The content of config/config.php:

Are you using external storage, if yes which one: local/smb/sftp/...
Yes webdav.

Are you using encryption:
No

Logs

{"reqId":"Gw6Y2yfpFYOsmY6Y\/ci3","remoteAddr":"HIDED_IP","app":"files_external","message":"Exception: {\"Exception\":\"OCP\\\\Files\\\\StorageNotAvailableException\",\"Message\":\"Sabre\\\\HTTP\\\\ClientException: Empty reply from server\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/dav.php(555): OC\\\\Files\\\\Storage\\\\DAV->convertException(Object(Sabre\\\\HTTP\\\\ClientException), '')\\n#1 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/common.php(435): OC\\\\Files\\\\Storage\\\\DAV->stat('')\\n#2 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/lib\\\/config.php(232): OC\\\\Files\\\\Storage\\\\Common->test(false)\\n#3 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/controller\\\/storagescontroller.php(244): OC_Mount_Config::getBackendStatus('\\\\OC\\\\Files\\\\Stora...', Array, false)\\n#4 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/controller\\\/userglobalstoragescontroller.php(112): OCA\\\\Files_External\\\\Controller\\\\StoragesController->updateStorageStatus(Object(OCA\\\\Files_external\\\\Lib\\\\StorageConfig))\\n#5 [internal function]: OCA\\\\Files_External\\\\Controller\\\\UserGlobalStoragesController->show(7)\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/http\\\/dispatcher.php(159): call_user_func_array(Array, Array)\\n#7 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/http\\\/dispatcher.php(89): OC\\\\AppFramework\\\\Http\\\\Dispatcher->executeController(Object(OCA\\\\Files_External\\\\Controller\\\\UserGlobalStoragesController), 'show')\\n#8 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/app.php(110): OC\\\\AppFramework\\\\Http\\\\Dispatcher->dispatch(Object(OCA\\\\Files_External\\\\Controller\\\\UserGlobalStoragesController), 'show')\\n#9 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/routing\\\/routeactionhandler.php(45): OC\\\\AppFramework\\\\App::main('UserGlobalStora...', 'show', Object(OC\\\\AppFramework\\\\DependencyInjection\\\\DIContainer), Array)\\n#10 [internal function]: OC\\\\AppFramework\\\\routing\\\\RouteActionHandler->__invoke(Array)\\n#11 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/route\\\/router.php(273): call_user_func(Object(OC\\\\AppFramework\\\\routing\\\\RouteActionHandler), Array)\\n#12 \\\/opt\\\/owncloud\\\/lib\\\/base.php(865): OC\\\\Route\\\\Router->match('\\\/apps\\\/files_ext...')\\n#13 \\\/opt\\\/owncloud\\\/index.php(39): OC::handleRequest()\\n#14 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/dav.php\",\"Line\":795}","level":3,"time":"2016-01-29T12:31:42+00:00"}

Client configuration

browser
Chrome

The text was updated successfully, but these errors were encountered:

SergioBertolinSG · 2016-01-29T12:39:30Z

cc @icewind1991

SergioBertolinSG · 2016-02-01T13:19:26Z

Happening the same using owncloud as external storage.

PVince81 · 2016-02-15T13:40:03Z

I guess you probably used the SSL checkbox, I just saw this: #21978 (comment)

The PR that fixes validation was fixed, can you try again with 9.0beta1 ?

PVince81 · 2016-02-17T10:49:13Z

Any update, is this still happening ?

SergioBertolinSG · 2016-02-17T12:08:25Z

Yes, now behaviour is a little different, red background appears, clicking on it appears a pop up saying:

There was an error with message: Sabre\HTTP\ClientException: Empty reply from server. Do you want to review mount point config in admin settings page?

Logs:

{"reqId":"+ql7ujvXn\/AgCqHiGvZr","remoteAddr":"IP","app":"files_external","message":"Empty reply from server","level":3,"time":"2016-02-17T12:05:13+00:00"}
{"reqId":"+ql7ujvXn\/AgCqHiGvZr","remoteAddr":"IP","app":"files_external","message":"Exception: {\"Exception\":\"OCP\\\\Files\\\\StorageNotAvailableException\",\"Message\":\"Sabre\\\\HTTP\\\\ClientException: Empty reply from server\",\"Code\":1,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/dav.php(555): OC\\\\Files\\\\Storage\\\\DAV->convertException(Object(Sabre\\\\HTTP\\\\ClientException), '')\\n#1 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/common.php(429): OC\\\\Files\\\\Storage\\\\DAV->stat('')\\n#2 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/lib\\\/config.php(232): OC\\\\Files\\\\Storage\\\\Common->test(false)\\n#3 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/controller\\\/storagescontroller.php(255): OC_Mount_Config::getBackendStatus('\\\\OC\\\\Files\\\\Stora...', Array, false)\\n#4 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/controller\\\/storagescontroller.php(302): OCA\\\\Files_External\\\\Controller\\\\StoragesController->updateStorageStatus(Object(OCA\\\\Files_external\\\\Lib\\\\StorageConfig))\\n#5 [internal function]: OCA\\\\Files_External\\\\Controller\\\\StoragesController->show(1)\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/http\\\/dispatcher.php(159): call_user_func_array(Array, Array)\\n#7 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/http\\\/dispatcher.php(89): OC\\\\AppFramework\\\\Http\\\\Dispatcher->executeController(Object(OCA\\\\Files_External\\\\Controller\\\\GlobalStoragesController), 'show')\\n#8 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/app.php(110): OC\\\\AppFramework\\\\Http\\\\Dispatcher->dispatch(Object(OCA\\\\Files_External\\\\Controller\\\\GlobalStoragesController), 'show')\\n#9 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/routing\\\/routeactionhandler.php(45): OC\\\\AppFramework\\\\App::main('GlobalStoragesC...', 'show', Object(OC\\\\AppFramework\\\\DependencyInjection\\\\DIContainer), Array)\\n#10 [internal function]: OC\\\\AppFramework\\\\routing\\\\RouteActionHandler->__invoke(Array)\\n#11 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/route\\\/router.php(273): call_user_func(Object(OC\\\\AppFramework\\\\routing\\\\RouteActionHandler), Array)\\n#12 \\\/opt\\\/owncloud\\\/lib\\\/base.php(856): OC\\\\Route\\\\Router->match('\\\/apps\\\/files_ext...')\\n#13 \\\/opt\\\/owncloud\\\/index.php(39): OC::handleRequest()\\n#14 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/dav.php\",\"Line\":795}","level":3,"time":"2016-02-17T12:05:13+00:00"}
{"reqId":"vgeh7qOh73RwbOJj+wsk","remoteAddr":"IP","app":"files_external","message":"Empty reply from server","level":3,"time":"2016-02-17T12:05:15+00:00"}
{"reqId":"vgeh7qOh73RwbOJj+wsk","remoteAddr":"IP","app":"files_external","message":"Exception: {\"Exception\":\"OCP\\\\Files\\\\StorageNotAvailableException\",\"Message\":\"Sabre\\\\HTTP\\\\ClientException: Empty reply from server\",\"Code\":1,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/dav.php(555): OC\\\\Files\\\\Storage\\\\DAV->convertException(Object(Sabre\\\\HTTP\\\\ClientException), '')\\n#1 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/common.php(429): OC\\\\Files\\\\Storage\\\\DAV->stat('')\\n#2 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/lib\\\/config.php(232): OC\\\\Files\\\\Storage\\\\Common->test(false)\\n#3 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/controller\\\/storagescontroller.php(255): OC_Mount_Config::getBackendStatus('\\\\OC\\\\Files\\\\Stora...', Array, false)\\n#4 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/controller\\\/globalstoragescontroller.php(178): OCA\\\\Files_External\\\\Controller\\\\StoragesController->updateStorageStatus(Object(OCA\\\\Files_external\\\\Lib\\\\StorageConfig))\\n#5 [internal function]: OCA\\\\Files_External\\\\Controller\\\\GlobalStoragesController->update(1, 'WebDAV', 'dav', 'password::sessi...', Array, Array, Array, Array, 100)\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/http\\\/dispatcher.php(159): call_user_func_array(Array, Array)\\n#7 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/http\\\/dispatcher.php(89): OC\\\\AppFramework\\\\Http\\\\Dispatcher->executeController(Object(OCA\\\\Files_External\\\\Controller\\\\GlobalStoragesController), 'update')\\n#8 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/app.php(110): OC\\\\AppFramework\\\\Http\\\\Dispatcher->dispatch(Object(OCA\\\\Files_External\\\\Controller\\\\GlobalStoragesController), 'update')\\n#9 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/appframework\\\/routing\\\/routeactionhandler.php(45): OC\\\\AppFramework\\\\App::main('GlobalStoragesC...', 'update', Object(OC\\\\AppFramework\\\\DependencyInjection\\\\DIContainer), Array)\\n#10 [internal function]: OC\\\\AppFramework\\\\routing\\\\RouteActionHandler->__invoke(Array)\\n#11 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/route\\\/router.php(273): call_user_func(Object(OC\\\\AppFramework\\\\routing\\\\RouteActionHandler), Array)\\n#12 \\\/opt\\\/owncloud\\\/lib\\\/base.php(856): OC\\\\Route\\\\Router->match('\\\/apps\\\/files_ext...')\\n#13 \\\/opt\\\/owncloud\\\/index.php(39): OC::handleRequest()\\n#14 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/private\\\/files\\\/storage\\\/dav.php\",\"Line\":795}","level":3,"time":"2016-02-17T12:05:15+00:00"}

Tested with daily master {"installed":true,"maintenance":false,"version":"9.0.0.11","versionstring":"9.0 beta 1","edition":""}

The https checkbox appears unchecked after going back to the admin page.

PVince81 · 2016-02-17T12:11:32Z

Are the login credentials valid for this ext storage ? If not, then that dialog would appear.

PVince81 · 2016-02-17T12:11:45Z

also, probably unrelated to SSL ?

SergioBertolinSG · 2016-02-17T12:13:52Z

Are the login credentials valid for this ext storage ?

Yes, they are valid, but still doesn't connect.

SergioBertolinSG · 2016-02-17T12:16:03Z

also, probably unrelated to SSL ?

It is related, mounting it without SSL works fine.

PVince81 · 2016-02-17T12:18:44Z

Ok, thanks for the info. Then there is indeed a bug with SSL + login credentials.

PVince81 · 2016-02-23T10:07:18Z

@SergioBertolinSG did you manually add "https" in the host field or did you just use the format "host/owncloud/remote.php/webdav" ?

LukasReschke · 2016-02-24T14:28:08Z

I stumbled upon the bug while debugging https://github.com/owncloud/core/issues/22605 … this has a security impact as it disables the whole SSL verification 🙈

The current logic is checking whether: 1. The returned value is a boolen 2. The returned value is a string and then matches for "true" Since the config is now written to the database the data is now a string with the value "1" if HTTPS is set to true. Effectively this option was thus always disabled at the moment, falling back to plain HTTP. This change casts the data to a boolean if it is defined as boolean. Fixes #22605 Fixes #22016

SergioBertolinSG · 2016-03-02T10:02:20Z

Still happening on 9.0.0rc1.

PVince81 · 2016-03-02T10:04:29Z

@SergioBertolinSG please work with @LukasReschke so he get reproduce the issue.

LukasReschke · 2016-03-02T10:06:08Z

Yes. Proper reproduction steps are required here. Server host etc. everything.

SergioBertolinSG · 2016-03-02T10:14:12Z

Like the original steps,just more detailed

serverA is a oC 9.0.0rc1
serverB is a oC 9.0.0rc1 with trustworthy certificate
both servers have admin user with same password.

Enable external storage app in serverA.
Mount serverB as webdav external storage using login credentials stored on database in serverA, use https and enable the checkbox. (Happens also with stored in session).
Login in serverA using admin.
See files view. Check webdav mountpoint folder.

SergioBertolinSG · 2016-03-02T14:08:17Z

OK, tested with a webdav server different than owncloud, using ssl. Working fine in 9.0rc1.

lock · 2019-08-05T21:00:37Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

SergioBertolinSG added Type:Bug app:files_external sev2-high labels Jan 29, 2016

SergioBertolinSG added this to the 9.0-current milestone Jan 29, 2016

SergioBertolinSG mentioned this issue Jan 29, 2016

Testing external storage new auth functionality owncloud/QA#101

Closed

PVince81 self-assigned this Feb 23, 2016

PVince81 mentioned this issue Feb 23, 2016

External storage: DAV broken on master against other ownCloud #22605

Closed

LukasReschke assigned LukasReschke and unassigned PVince81 Feb 24, 2016

LukasReschke added security regression sev1-critical and removed sev2-high labels Feb 24, 2016

LukasReschke mentioned this issue Feb 24, 2016

Fix HTTPS support on external storages #22636

Merged

DeepDiver1975 added the in progress label Feb 24, 2016

DeepDiver1975 closed this as completed in #22636 Feb 25, 2016

DeepDiver1975 removed the in progress label Feb 25, 2016

SergioBertolinSG reopened this Mar 2, 2016

LukasReschke added needs info sev2-high and removed sev1-critical labels Mar 2, 2016

LukasReschke assigned SergioBertolinSG and unassigned LukasReschke Mar 2, 2016

SergioBertolinSG closed this as completed Mar 2, 2016

SergioBertolinSG added tested and removed needs info labels Mar 2, 2016

lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSL connection doesn't happen when using login credentials with webdav external storage. #22016

SSL connection doesn't happen when using login credentials with webdav external storage. #22016

SergioBertolinSG commented Jan 29, 2016

SergioBertolinSG commented Jan 29, 2016

SergioBertolinSG commented Feb 1, 2016

PVince81 commented Feb 15, 2016

PVince81 commented Feb 17, 2016

SergioBertolinSG commented Feb 17, 2016

PVince81 commented Feb 17, 2016

PVince81 commented Feb 17, 2016

SergioBertolinSG commented Feb 17, 2016

SergioBertolinSG commented Feb 17, 2016

PVince81 commented Feb 17, 2016

PVince81 commented Feb 23, 2016

LukasReschke commented Feb 24, 2016

SergioBertolinSG commented Mar 2, 2016

PVince81 commented Mar 2, 2016

LukasReschke commented Mar 2, 2016

SergioBertolinSG commented Mar 2, 2016

SergioBertolinSG commented Mar 2, 2016

lock bot commented Aug 5, 2019

SSL connection doesn't happen when using login credentials with webdav external storage. #22016

SSL connection doesn't happen when using login credentials with webdav external storage. #22016

Comments

SergioBertolinSG commented Jan 29, 2016

Steps to reproduce

Expected behaviour

Actual behaviour

Server configuration

Client configuration

SergioBertolinSG commented Jan 29, 2016

SergioBertolinSG commented Feb 1, 2016

PVince81 commented Feb 15, 2016

PVince81 commented Feb 17, 2016

SergioBertolinSG commented Feb 17, 2016

PVince81 commented Feb 17, 2016

PVince81 commented Feb 17, 2016

SergioBertolinSG commented Feb 17, 2016

SergioBertolinSG commented Feb 17, 2016

PVince81 commented Feb 17, 2016

PVince81 commented Feb 23, 2016

LukasReschke commented Feb 24, 2016

SergioBertolinSG commented Mar 2, 2016

PVince81 commented Mar 2, 2016

LukasReschke commented Mar 2, 2016

SergioBertolinSG commented Mar 2, 2016

SergioBertolinSG commented Mar 2, 2016

lock bot commented Aug 5, 2019