Switch between email and password in user creation form issue

[PVince81]

Steps

1. Setup OC
2. Go to the users page
3. Type "user1"
4. In the email field type "test", believing that this was the password field. Leave the value in the field.
5. Click on the cog icon at the bottom left
6. Click "Set password for user", this toggles the email field to be a password field
7. Type in "test" as password
8. Click "create"

Expected result

User created.

Actual result

Error message about invalid email address.
This is because the email field is just hidden and still has its value.

Solution is to either:

1. clear the field automatically when toggling
   or
2. ignore the hidden field when gathering form values

Version

ownCloud 10.0.1 RC1

[ownclouders]

GitMate.io thinks possibly related issues are #27612 (Password forgotten usability issues), #4491 (Design issues with password change), #30511 (Password Email wont Set), #4538 (Some issue with password), and #16442 (How to disable user password reset?).

[davitol]

@PVince81 Maybe this exception thrown is related?

ErrorException: Undefined index: add_password
  File "/var/www/owncloud/settings/templates/users/main.php", line 85, in handleError
    class="checkbox" <?php if ($_['add_password'] === 'true') {
  File "/var/www/owncloud/settings/templates/users/main.php", line 85, in include
    class="checkbox" <?php if ($_['add_password'] === 'true') {
  File "/var/www/owncloud/lib/private/Template/Base.php", line 219, in load
    include $file;
  File "/var/www/owncloud/lib/private/Template/Base.php", line 194, in fetchPage
    return $this->load($this->template, $additionalParams);
  File "/var/www/owncloud/lib/private/legacy/template.php", line 236, in fetchPage
    $data = parent::fetchPage($additionalParams);
...
(6 additional frame(s) were not displayed)

[PVince81]

the exception is handled in #32621

this ticket here is not critical, moving to backlog for next release

[phil-davis]

PR #39306 fixes this. I have tested manually.