OC_Migrate still uses MDB2 Schem Migration

[DeepDiver1975]

In order to fully get rid of MDB2 this is a necessary step.

@bartv2 Can I ask you to take care? THX

[DeepDiver1975]

Hey @tomneedham is there any chance to take care of this?
Maybe we can try to fix this within the next 2 weeks otherwise I think we need to kill these classes.

THX

[tomneedham]

Yes I will make this my priority

[DeepDiver1975]

@tomneedham any news? THX

[tomneedham]

@bartv2 You're the go-to guy for doctrine right? Are you around this evening for me to bounce questions off?

[bartv2]

@tomneedham sorry, got some time on friday during the day

[DeepDiver1975]

@tomneedham time's up 😉 what shall we do now?

It's a like a bad joke that we moves away from mdb2 with exception of this piece

@bartv2 any time left to help out here?

I'll prepare a pull request next week to drop the whole migration stuff if there is no progress - THX

@karlitschek FYI

[tomneedham]

Unfortunately I just don't have the hours to learn the new doctrine stuff and implement it without help. I had a look through the code and initially came across the issue that it doesn't seem possible with the new OC_DB to connect to other databases (like the sqlite db we generate for the zip file).

[tomneedham]

Also as mentioned in my post to the list, on one of these issues on github we agreed to retire the admin_migrate app due to its very limited use case.

[karlitschek]

any update here?

[tomneedham]

It works. But wanted to add a unit test. For some reason an error is generated: #6650. Would like @bartv2 to take a look as he engineered the move to doctrine. I think there still needs to be edits to this method: https://github.com/owncloud/core/blob/migration_unit_tests/lib/private/migrate.php#L470

[karlitschek]

@tomneedham Can we close this?

[tomneedham]

Upon second review #6650

[karlitschek]

done :-)

[bartv2]

#6650 is merged