Change OC_Migrate from MDB2 to Doctrine

[bartv2]

Solves #5388
@tomneedham @DeepDiver1975

[karlitschek]

Sweet!! Thanks a lot @bartv2 👍 Haven't tested

[DeepDiver1975]

@bartv2 can we add a unit test? thx

[karlitschek]

ping

[tomneedham]

@bartv2 the migration now runs, but I can't see that the migration.db sqlite database is actually generated?

[bartv2]

@tomneedham what do you mean, here https://github.com/owncloud/core/pull/6005/files#diff-6dcfe22b2c6accaeb57bd13238358382R456 the database is created. here https://github.com/owncloud/core/pull/6005/files#diff-6dcfe22b2c6accaeb57bd13238358382R488 the tables are created.

[tomneedham]

@bartv2 In the resulting zip file that is sent to the user, there is no migration.db present.

[tomneedham]

@bartv2 Can you take a look at this? The export runs ok but I don't see a migration.db generated in the export zip.

[schiessle]

I'm quite sure that the tests fail because of this commit. We had the same problem with the xsendfile pull request. Why do we change the 3rdparty reference in this pull request?

[tomneedham]

@bartv2 ?

[bartv2]

The commit without this also failes the ci tests. The only changes in those commits are:

• add php-cloudfiles
• something with CommentOnColumnSQL
• remove MDB2
  thus, not very critical

[bartv2]

Can you take a look at this? The export runs ok but I don't see a migration.db generated in the export zip.

I checked, only the user export has a migration.db which is also what the code suggests.

[ghost]

Test failed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2409/

[tomneedham]

@bartv2 which applications did you have installed that use migration of db content?

[tomneedham]

@bartv We need to change this code to doctrine too:

core/lib/private/migrate.php

Line 467 in 8f0c56c

static private function createAppTables( $appid ) {

When migrating it tries to recreate the tables in the new instance (which may already be there). I get the following for example when migrating the calendar to an instance with the calendar already installed:

An exception occurred while executing 'CREATE TABLE "clndr_objects" ("id" INTEGER NOT NULL, "calendarid" INTEGER DEFAULT 0 NOT NULL, "objecttype" VARCHAR(40) DEFAULT '' NOT NULL, "startdate" DATETIME DEFAULT '1970-01-01 00:00:00', "enddate" DATETIME DEFAULT '1970-01-01 00:00:00', "repeating" INTEGER DEFAULT 0, "summary" VARCHAR(255) DEFAULT NULL, "calendardata" CLOB DEFAULT NULL, "uri" VARCHAR(255) DEFAULT NULL, "lastmodified" INTEGER DEFAULT 0, PRIMARY KEY("id"))': SQLSTATE[HY000]: General error: 1 table "clndr_objects" already exists

[bartv2]

@tomneedham createAppTables is only used when exporting, so not sure how you get that error

[ghost]

Test passed.
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/2460/

[tomneedham]

👍 Just need to work on unit tests. Not going to be easy.