Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for sharing #60

Closed
DeepDiver1975 opened this issue Oct 23, 2012 · 4 comments
Closed

Add unit tests for sharing #60

DeepDiver1975 opened this issue Oct 23, 2012 · 4 comments
Milestone

Comments

@DeepDiver1975
Copy link
Member

The PHPUnit Coverage analysis shows room for improvement:
https://ci.tmit.eu/job/ownCloud-Server%28master%29/cloverphp/lib_public_share.php.html

Please implement php unit tests for following topics:

  • Share a folder
  • Share with link
  • unshareAll
  • share with expiry date

Feel free to ask questions on the comments below.

@fmms
Copy link
Contributor

fmms commented Nov 5, 2012

How is this related to #151?

@DeepDiver1975
Copy link
Member Author

Not at all. Thats the second issue which causes build breaks.

For this one I'll submit a pull request soon.

Thx

fmms notifications@github.com schrieb:

How is this related to #151?


Reply to this email directly or view it on GitHub:
#60 (comment)

@Niduroki
Copy link
Member

bump
how does https://github.com/owncloud/core/blob/master/tests/lib/share/share.php fare/where should stuff be improved?

@DeepDiver1975
Copy link
Member Author

Michael's sharing rewrite has 100% test coverage. Nothing to do.

aditmeno pushed a commit to aditmeno/Aeolus that referenced this issue Apr 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants