Deprecate OC_JSON and OCP\JSON
#14129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates – but not removes – those two classes and all functions in it. There is no reason that new developments should use those methods as with the AppFramework there is a replacement that allows testable code. With the `@deprecated` annotation IDEs like PHPStorm will point out to the developer that a functionality is deprecated and that there is a better suited replacement.
|
The inspection completed: 397 new issues |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -31,141 +30,142 @@ | |||
| namespace OCP; | |||
|
|
|||
| /** | |||
| * This class provides convinient functions to generate and send JSON data. Usefull for Ajax calls | |||
| * This class provides convenient functions to generate and send JSON data. Useful for Ajax calls | |||
| * @deprecated Use a AppFramework JSONResponse instead | |||
There was a problem hiding this comment.
Please specify the time range for public APIs
There was a problem hiding this comment.
Well, that would require that we have a consensus on that first. => Out of scope for this PR.
|
fine with me 👍 |
|
👍 |
MorrisJobke
added a commit
that referenced
this pull request
Feb 12, 2015
Deprecate `OC_JSON` and `OCP\JSON`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates – but not removes – those two classes and all functions in it. There is no reason that new developments should use those methods as with the AppFramework there is a replacement that allows testable code (this code uses
exit()and other anti-patterns that makes testing such code impossible). This change set also corrects some PHPDocs.With the
@deprecatedannotation IDEs like PHPStorm will point out to the developer that a functionality is deprecated and that there is a better suited replacement.cc @DeepDiver1975 @karlitschek