Setup command #14416

DeepDiver1975 · 2015-02-21T19:56:30Z

@LukasReschke @PVince81 @th3fallen @icewind1991 please review - THX

In case the owncloud instance is not yet setup the number of commands will be pretty short:

$ ./occ list
ownCloud is not installed - only a limited number of commands are available
ownCloud version 8.1 alpha 1

Usage:
 [options] command [arguments]

Options:
 --help (-h)           Display this help message
 --quiet (-q)          Do not output any message
 --verbose (-v|vv|vvv) Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug
 --version (-V)        Display this application version
 --ansi                Force ANSI output
 --no-ansi             Disable ANSI output
 --no-interaction (-n) Do not ask any interactive question

Available commands:
 check                 check dependencies of the server environment
 help                  Displays help for a command
 list                  Lists commands
 status                show some status information
app
 app:check-code        check code to be compliant
l10n
 l10n:createjs         Create javascript translation files for a given app
maintenance
 maintenance:install   install ownCloud

maintenance:install is the command to be used for installing an instance via the console:

$ ./occ help maintenance:install
ownCloud is not installed - only a limited number of commands are available
Usage:
 maintenance:install [--database="..."] [--database-name="..."] [--database-host="..."] [--database-user="..."] [--database-pass="..."] [--database-table-prefix[="..."]] [--admin-user="..."] [--admin-pass="..."] [--data-dir="..."]

Options:
 --database               Supported database type (default: "sqlite")
 --database-name          Name of the database
 --database-host          Hostname of the database (default: "localhost")
 --database-user          User name to connect to the database
 --database-pass          Password of the database user
 --database-table-prefix  Prefix for all tables (default: oc_)
 --admin-user             User name of the admin account (default: "admin")
 --admin-pass             Password of the admin account
 --data-dir               Path to data directory (default: "/home/deepdiver/Development/ownCloud/core-autotest/data")
 --help (-h)              Display this help message
 --quiet (-q)             Do not output any message
 --verbose (-v|vv|vvv)    Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug
 --version (-V)           Display this application version
 --ansi                   Force ANSI output
 --no-ansi                Disable ANSI output
 --no-interaction (-n)    Do not ask any interactive question

ghost · 2015-02-21T20:21:03Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9831/
Test PASSed.

LukasReschke · 2015-02-21T20:42:59Z

console.php

 			}
+		} else {
+			echo "ownCloud or on of the apps require upgrade - only a limited number of commands is available" . PHP_EOL;


karlitschek · 2015-02-22T16:48:32Z

nice 👍

ghost · 2015-02-22T17:41:41Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9833/
Test PASSed.

bantu · 2015-02-22T20:18:59Z

core/command/maintenance/install.php

+			throw new InvalidArgumentException("Database <$db> is not supported.");
+		}
+
+		$dbUser = $input->getOption('database-user');


Build $options array here instead?

ghost · 2015-02-23T10:47:03Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9845/
Test PASSed.

ghost · 2015-02-23T16:11:54Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9864/
Test PASSed.

DeepDiver1975 · 2015-02-23T16:18:56Z

@bantu @Xenopathic any further objections? Otherwise I'd like to merge this - THX

RobinMcCorkell · 2015-02-23T16:31:32Z

Just tested with no options: it attempts to create an sqlite database, then just prints 'Array' and fails. The oC instance isn't installed properly.

EDIT: Same thing when trying to create a MySQL instance.

Logs say it is at core/command/maintenance/install.php#49: Array to string conversion

RobinMcCorkell · 2015-02-23T16:36:22Z

During the failed MySQL installation, the DB pass isn't written to the config, which probably explains part of the errors.

DeepDiver1975 · 2015-02-23T16:40:14Z

THX - well - this is because of this bloody errors array being returned and holding different data types ..... 😠

DeepDiver1975 · 2015-02-23T16:46:46Z

@Xenopathic you might want to try it again - thanks for testing!

ghost · 2015-02-23T17:11:54Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9869/
Test PASSed.

RobinMcCorkell · 2015-02-23T19:28:35Z

Well I tried my best to break it... but couldn't. Looks like it's a nice robust solution! Only issue I can see is a minor one: the config.php is generated with a NULL trusted_domain, and a bad overwrite.cli.url field: http:///.. I don't know what the implications of this are.

Otherwise, 👍

LukasReschke · 2015-02-23T19:34:31Z

NULL trusted_domain

That's erm not really good - we need to have at least one trusted domain or it won't work in real life deployments. (localhost is always whitelisted)

DeepDiver1975 · 2015-02-23T20:01:21Z

That's erm not really good - we need to have at least one trusted domain or it won't work in real life deployments. (localhost is always whitelisted)

I'll have a look ....

DeepDiver1975 · 2015-02-23T20:50:46Z

@LukasReschke @Xenopathic please review and test again - thanks a lot!

scrutinizer-notifier · 2015-02-23T21:15:49Z

The inspection completed: 11 new issues, 6 updated code elements

ghost · 2015-02-23T21:20:43Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9874/
Test PASSed.

LukasReschke · 2015-02-23T21:30:15Z

Works if executed as webserver user - nice! 👍

Once #14357 is merged the .htaccess will also get generated properly.

RobinMcCorkell · 2015-02-23T21:30:24Z

This time I see localhost for both trusted_domains and overwrite.cli.url. While there is no other way around trusted_domains that I can see (once installed, the admin can add a trusted domain easily), perhaps the overwrite.cli.url parameter should be left empty?

LukasReschke · 2015-02-23T21:31:46Z

This time I see localhost for both trusted_domains and overwrite.cli.url. While there is no other way around trusted_domains that I can see (once installed, the admin can add a trusted domain easily), perhaps the overwrite.cli.url parameter should be left empty?

That will lead to quite some broken stuff. IMHO it's okay to have this defaulting to localhost as people using occ should be anyways able to configure their system properly afterwards 🙈

RobinMcCorkell · 2015-02-23T21:32:39Z

Right, in that case, 👍 🚀

DeepDiver1975 · 2015-02-23T21:41:01Z

Thanks for testing and review, gentlemen!

Setup command

PVince81 · 2015-03-16T16:56:17Z

This broke master due to "OC_Config" having been omitted.

Did Jenkins lie about this PR passing ?

LukasReschke · 2015-03-16T16:57:39Z

Did Jenkins lie about this PR passing ?

No. The ~~namespace~~OC_Config was added later… The PR passed fine in the first test run.

PVince81 · 2015-03-16T17:01:53Z

Fix here: #14936

DeepDiver1975 added this to the 8.1-next milestone Feb 21, 2015

DeepDiver1975 added the 3 - To Review label Feb 21, 2015

LukasReschke reviewed Feb 21, 2015
View reviewed changes

bantu reviewed Feb 22, 2015
View reviewed changes

DeepDiver1975 force-pushed the setup-command branch from 621e67e to 3d5e6ea Compare February 23, 2015 10:20

Fix namespace of OC_Setup -> \OC\Setup

1fd1b35

DeepDiver1975 force-pushed the setup-command branch from 3d5e6ea to f46d8ca Compare February 23, 2015 15:46

implement command maintenance:install

bcd10d3

DeepDiver1975 force-pushed the setup-command branch from f46d8ca to bcd10d3 Compare February 23, 2015 15:47

Fix error handling

eae6471

properly initialize OC::$WEBROOT and host name

0a9b824

DeepDiver1975 added a commit that referenced this pull request Feb 23, 2015

Merge pull request #14416 from owncloud/setup-command

e87ada8

Setup command

DeepDiver1975 merged commit e87ada8 into master Feb 23, 2015

DeepDiver1975 deleted the setup-command branch February 23, 2015 21:41

MorrisJobke mentioned this pull request Apr 23, 2015

Install command owncloud-archive/documentation#1075

Closed

carlaschroder mentioned this pull request Apr 30, 2015

document additions to occ command 8.1 owncloud-archive/documentation#1094

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup command #14416

Setup command #14416

DeepDiver1975 commented Feb 21, 2015

ghost commented Feb 21, 2015

LukasReschke Feb 21, 2015

karlitschek commented Feb 22, 2015

ghost commented Feb 22, 2015

bantu Feb 22, 2015

ghost commented Feb 23, 2015

ghost commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

ghost commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

LukasReschke commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

scrutinizer-notifier commented Feb 23, 2015

ghost commented Feb 23, 2015

LukasReschke commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

LukasReschke commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

PVince81 commented Mar 16, 2015

LukasReschke commented Mar 16, 2015

PVince81 commented Mar 16, 2015

Setup command #14416

Setup command #14416

Conversation

DeepDiver1975 commented Feb 21, 2015

ghost commented Feb 21, 2015

LukasReschke Feb 21, 2015

Choose a reason for hiding this comment

karlitschek commented Feb 22, 2015

ghost commented Feb 22, 2015

bantu Feb 22, 2015

Choose a reason for hiding this comment

ghost commented Feb 23, 2015

ghost commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

ghost commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

LukasReschke commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

scrutinizer-notifier commented Feb 23, 2015

ghost commented Feb 23, 2015

LukasReschke commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

LukasReschke commented Feb 23, 2015

RobinMcCorkell commented Feb 23, 2015

DeepDiver1975 commented Feb 23, 2015

PVince81 commented Mar 16, 2015

LukasReschke commented Mar 16, 2015

PVince81 commented Mar 16, 2015