Add a repair step to delete old tables #14638
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Works 👍 |
|
👍 nice |
|
Can you write a unit test ?
I know the code looks straightforward, but who knows what can happen with Oracle... |
| $this->emit('\OC\Repair', 'info', [ | ||
| sprintf('Table %s has been deleted', $tableName) | ||
| ]); | ||
| $this->connection->dropTable($tableName); |
There was a problem hiding this comment.
dropTable could throw an exception which we better catch and log and do not fall apart
There was a problem hiding this comment.
The doc block does not say something like that 🙈
And also if that thing fails, it has to be due to broken DB credentials, and then other things will bring that to the users attention?
There was a problem hiding this comment.
And also if that thing fails, it has to be due to broken DB credentials,
will 💣 earlier
@nickvergessen yes - this is required - THX |
|
Test added |
|
The inspection completed: 6 new issues, 9 updated code elements |
|
Refer to this link for build results (access rights to CI server needed): |
|
👍 |
…ld-tables Add a repair step to delete old tables
@blizzz @RealRancor @DeepDiver1975
Fix #14538