-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Download from URL" feature #14652
Conversation
@DeepDiver1975 @nickvergessen Please review and test. THX. |
@@ -12,37 +12,6 @@ | |||
$dir = isset( $_REQUEST['dir'] ) ? '/'.trim((string)$_REQUEST['dir'], '/\\') : ''; | |||
$filename = isset( $_REQUEST['filename'] ) ? trim((string)$_REQUEST['filename'], '/\\') : ''; | |||
$content = isset( $_REQUEST['content'] ) ? (string)$_REQUEST['content'] : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content us unused as well and can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core/apps/files/ajax/newfile.php
Line 69 in acabd81
$success = \OC\Files\Filesystem::file_put_contents($target, $content); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the text editor uses that…
tested 👍 |
The inspection completed: 3 new issues |
Refer to this link for build results (access rights to CI server needed): |
👍 |
File + folder creation still work 👍 |
Remove "Download from URL" feature
Add to the "features" wiki page ? |
Already done yesterday 😄 |
We should search in the issues for related reports and close them all |
only found #6814 |
Great stuff. Now is also the time to do the combined »New« menu (put upload in there as well) since there’s just 2 items in there now. See #7031 @MorrisJobke let’s look at that as well in Nürnberg? |
Yep :) |
Too bad to see this is gone :). Maybe an improved version could be done as an external app :). |
Hello, Will this PR be backported in OC 7 ? |
No. |
Thx for this quick answer. |
Fixes #13326