Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Download from URL" feature #14652

Merged
merged 2 commits into from
Mar 3, 2015
Merged

Remove "Download from URL" feature #14652

merged 2 commits into from
Mar 3, 2015

Conversation

LukasReschke
Copy link
Member

Fixes #13326

@LukasReschke LukasReschke added this to the 8.1-current milestone Mar 2, 2015
@LukasReschke
Copy link
Member Author

@DeepDiver1975 @nickvergessen Please review and test. THX.

@@ -12,37 +12,6 @@
$dir = isset( $_REQUEST['dir'] ) ? '/'.trim((string)$_REQUEST['dir'], '/\\') : '';
$filename = isset( $_REQUEST['filename'] ) ? trim((string)$_REQUEST['filename'], '/\\') : '';
$content = isset( $_REQUEST['content'] ) ? (string)$_REQUEST['content'] : '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content us unused as well and can be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$success = \OC\Files\Filesystem::file_put_contents($target, $content);
🙈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text editor uses that…

@DeepDiver1975
Copy link
Member

tested 👍

@scrutinizer-notifier
Copy link

The inspection completed: 3 new issues

@ghost
Copy link

ghost commented Mar 2, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10149/
Test PASSed.

@nickvergessen
Copy link
Contributor

👍

@PVince81
Copy link
Contributor

PVince81 commented Mar 3, 2015

File + folder creation still work 👍

PVince81 pushed a commit that referenced this pull request Mar 3, 2015
@PVince81 PVince81 merged commit 133c37f into master Mar 3, 2015
@PVince81 PVince81 deleted the kill-download-from-url branch March 3, 2015 09:10
@PVince81
Copy link
Contributor

PVince81 commented Mar 3, 2015

Add to the "features" wiki page ?

@LukasReschke
Copy link
Member Author

Already done yesterday 😄

@DeepDiver1975
Copy link
Member

We should search in the issues for related reports and close them all

@nickvergessen
Copy link
Contributor

only found #6814

@jancborchardt
Copy link
Member

Great stuff. Now is also the time to do the combined »New« menu (put upload in there as well) since there’s just 2 items in there now. See #7031

@MorrisJobke let’s look at that as well in Nürnberg?

@MorrisJobke
Copy link
Contributor

@MorrisJobke let’s look at that as well in Nürnberg?

Yep :)

@vgezer
Copy link
Contributor

vgezer commented Mar 10, 2015

Too bad to see this is gone :). Maybe an improved version could be done as an external app :).

@ppaysant
Copy link
Contributor

Hello,

Will this PR be backported in OC 7 ?

@LukasReschke
Copy link
Member Author

Will this PR be backported in OC 7 ?

No.

@ppaysant
Copy link
Contributor

Thx for this quick answer.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "Download from URL" configurable
9 participants