Allow Remote avatars #14856

rullzer · 2015-03-13T08:16:39Z

Added a function to the avatar controller to deal with remote avatar calls. This function takes as input the userId, size and the share token.

This share token is used to retrieve the share, It is then matched against the userId. There are two possible scenario's.

If userA (on instance A) shares with userB (on instance B).

userB can request the avatar from userA, but user A cannot yet request the avatar from userB.
if userB has accepted the share userA can also request the avatar from userB.

Still todo:

Some new js logic is required to properly fetch remote avatars.
UserA should check if the share is accepted before sending the request

Future work:

Cacheing

rullzer · 2015-03-13T08:18:33Z

@LukasReschke passing the share token around is not a problem I assume since we do it as well to initiate s2s shares?

CC @PVince81

LukasReschke · 2015-03-13T08:42:07Z

Mhm. Thinking twice about it in my opinion it's also okay to not require any share token at all and just expose all avatars. That would allow other use-cases as well.

But that would then need to be documented somewhere. I can take care of that…

rullzer · 2015-03-13T08:44:45Z

That would be simpler indeed.

LukasReschke · 2015-03-13T08:49:06Z

Generally speaking: Exposing information is okay as long as we don't give a full list of users to unauthenticated 3rdparties and it is documented and can so be considered part of the threatmodel.

nickvergessen · 2015-03-13T11:52:39Z

core/avatar/avatarcontroller.php

+			return new DataResponse([], Http::STATUS_BAD_REQUEST);
+		}
+
+		return $this->getAvatar($userId, $size);


Please add a check for $size to avoid problems when someone tries to fool us?

the getAvatar function already checks size

rullzer · 2015-03-16T07:43:35Z

If we will allow all avatars to be fetched anyway this PR is obsolete. Since then everybody could just use the default avatar interface.

However, this would make it possible to get the entered name of the user if no avatar is set. Is this acceptable?

DeepDiver1975 · 2015-03-30T07:18:30Z

rescheduling this for 8.2 - we are entering freeze for 8.1 tomorrow

jancborchardt · 2015-06-29T15:42:21Z

@rullzer @schiesbn what’s the status here? This is pretty cool for federated sharing. :)

nickvergessen · 2015-06-30T07:54:16Z

@jancborchardt the status is 8.2 is less important then 8.1 at the moment ;)

rullzer · 2015-07-01T07:54:55Z

@jancborchardt well it should not be hard.

Howeverer,

we need to agree on an endpoint that can be used and will not change (CC: @DeepDiver1975)
we do not want to leak to much sensitive information (CC: @LukasReschke)

Just serving the image is easy... the other stuff might need some discussion. Also not that hard but choices have to be made :)

rullzer · 2015-07-21T13:50:28Z

I'd like to continue this. So that 8.2 can have awesome remote avatars!

The code now has tests!

@DeepDiver1975 the current path is: index.php/avatar///remote?token= is that fine or should that be modified? For me it makes sense to have all the avatar routes grouped

@LukasReschke should I switch back to 1 response code to make it harder to get info?

nickvergessen · 2015-07-22T06:19:15Z

core/avatar/avatarcontroller.php

+	/**
+	 * Return an avatar for remote shares. If userA shares with userB there are multiple scenarios
+	 *  - userB did not yet accept the share. userB can retrieve avatar of userA with the token
+	 *  - userB accepts the share. Now userA can retrieve the avatar of UserB


The problem with this is, that the activity app can therefor not make any use of remote avatars at all?
Or we need to make two requests: 1. check if the image is served and then embed the code for the avatar 2. load the avatar
Are avatars really so secret, that we can not allow displaying them?

Well it would make the code easier of course. And indeed make avatars also better usable for other apps.

I don't think they are that secret. But maybe other people do...

LukasReschke · 2015-07-27T19:05:36Z

Thinking about this again I'd just expose avatar#getAvatar to the public. Reduces code and avatars are not that sensitive.

rullzer · 2015-07-27T19:08:12Z

@LukasReschke ok that should be easier. Of course it then could also expose the full name (if no avatar is set).

I'll modify the PR. Should get a lot simpler.

rullzer · 2015-07-28T10:49:54Z

That is better. avatar#getAvatar is public now.

Extra test is added if the user exists.
Unit tests are updated.

Pretty simple really.

Review time.

rullzer · 2015-08-06T16:05:30Z

Review time: @LukasReschke @MorrisJobke @PVince81 @Xenopathic @nickvergessen

should not be hard.

LukasReschke · 2015-08-10T09:02:40Z

core/avatar/avatarcontroller.php

@@ -84,12 +84,18 @@ public function __construct($appName,

 	/**
 	 * @NoAdminRequired


PublicPage implies this. Redundant.

LukasReschke · 2015-08-10T09:03:10Z

Besides my remark: Should be good to go 👍

DeepDiver1975 · 2015-08-10T09:09:07Z

so this is supposed to be a public api - right?
Should be done via OCS or WebDAV

LukasReschke · 2015-08-10T09:10:48Z

so this is supposed to be a public api - right?
Should be done via OCS or WebDAV

OCS can per definition not serve arbitrary binary content. We really do not want to go base64 encode data for this purpose.

WebDAV, well… would require some more insight on the plans here first.

DeepDiver1975 · 2015-08-10T09:14:19Z

WebDAV, well… would require some more insight on the plans here first.

DeepDiver1975/dav#2

DeepDiver1975 · 2015-08-10T09:15:12Z

OCS can per definition not serve arbitrary binary content.

hmmm

rullzer · 2015-08-19T13:14:10Z

So probably best to wait with this PR until after the conference where @DeepDiver1975 will present us his idea's for more webdav related stuff.

rullzer · 2015-08-29T12:45:22Z

@jancborchardt this is the PR for the avatars

MorrisJobke · 2015-08-29T12:48:14Z

@jancborchardt this is the PR for the avatars

... and it needs a rebase ;)

scrutinizer-notifier · 2015-08-29T13:22:28Z

A new inspection was created.

ghost · 2015-08-29T13:24:44Z

🚀 Test PASSed.🚀

MorrisJobke · 2015-08-29T16:05:30Z

Works 👍

Allow Remote avatars

DeepDiver1975 · 2015-09-15T14:52:08Z

why was this merged?

there are open todos and the approach is still questionable

tobiasKaminsky · 2016-02-10T20:22:30Z

@DeepDiver1975 Any news about this PR?
We, android app, want to integrate this, but then the api should stay the same?

lock · 2019-08-07T19:01:36Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

rullzer added 2 - Developing feature:avatars labels Mar 13, 2015

rullzer added this to the 8.1-current milestone Mar 13, 2015

rullzer mentioned this pull request Mar 13, 2015

Show remote user's avatar for server to server shares #14564

Closed

nickvergessen reviewed Mar 13, 2015
View reviewed changes

DeepDiver1975 modified the milestones: 8.2-next, 8.1-current Mar 30, 2015

jancborchardt added enhancement design feature:sharing labels May 1, 2015

jancborchardt added the feature:federated-cloud-sharing label Jun 29, 2015

LukasReschke mentioned this pull request Jul 1, 2015

Avatar route #17305

Closed

tobiasKaminsky mentioned this pull request Jul 1, 2015

Show avatar in account list owncloud/android#778

Closed

nickvergessen reviewed Jul 22, 2015
View reviewed changes

LukasReschke mentioned this pull request Jul 27, 2015

Uploader: don’t make the account choice a blocking popup owncloud/android#1046

Closed

rullzer added the 3 - To Review label Jul 28, 2015

rullzer removed the 2 - Developing label Jul 28, 2015

rullzer changed the title ~~[WIP] Remote avatars~~ Allow Remote avatars Jul 28, 2015

LukasReschke reviewed Aug 10, 2015
View reviewed changes

Allow remote avatars

ae62537

MorrisJobke added a commit that referenced this pull request Aug 29, 2015

Merge pull request #14856 from rullzer/remote_avatars

90dfa98

Allow Remote avatars

MorrisJobke merged commit 90dfa98 into owncloud:master Aug 29, 2015

nickvergessen mentioned this pull request Aug 29, 2015

Display remote avatars on federated cloud ids owncloud/activity#382

Closed

DeepDiver1975 mentioned this pull request Sep 15, 2015

Revert "Allow Remote avatars" #19052

Merged

AndyScherzinger mentioned this pull request Feb 8, 2016

Remote Operation to load given user's avatar owncloud/android-library#107

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow Remote avatars #14856

Allow Remote avatars #14856

rullzer commented Mar 13, 2015

rullzer commented Mar 13, 2015

LukasReschke commented Mar 13, 2015

rullzer commented Mar 13, 2015

LukasReschke commented Mar 13, 2015

nickvergessen Mar 13, 2015

rullzer Mar 16, 2015

rullzer commented Mar 16, 2015

DeepDiver1975 commented Mar 30, 2015

jancborchardt commented Jun 29, 2015

nickvergessen commented Jun 30, 2015

rullzer commented Jul 1, 2015

rullzer commented Jul 21, 2015

nickvergessen Jul 22, 2015

rullzer Jul 22, 2015

LukasReschke commented Jul 27, 2015

rullzer commented Jul 27, 2015

rullzer commented Jul 28, 2015

rullzer commented Aug 6, 2015

LukasReschke Aug 10, 2015

rullzer Aug 10, 2015

LukasReschke commented Aug 10, 2015

DeepDiver1975 commented Aug 10, 2015

LukasReschke commented Aug 10, 2015

DeepDiver1975 commented Aug 10, 2015

DeepDiver1975 commented Aug 10, 2015

rullzer commented Aug 19, 2015

rullzer commented Aug 29, 2015

MorrisJobke commented Aug 29, 2015

scrutinizer-notifier commented Aug 29, 2015

ghost commented Aug 29, 2015

MorrisJobke commented Aug 29, 2015

DeepDiver1975 commented Sep 15, 2015

tobiasKaminsky commented Feb 10, 2016

lock bot commented Aug 7, 2019

		@@ -84,12 +84,18 @@ public function __construct($appName,

		/**
		* @NoAdminRequired

Allow Remote avatars #14856

Allow Remote avatars #14856

Conversation

rullzer commented Mar 13, 2015

rullzer commented Mar 13, 2015

LukasReschke commented Mar 13, 2015

rullzer commented Mar 13, 2015

LukasReschke commented Mar 13, 2015

nickvergessen Mar 13, 2015

Choose a reason for hiding this comment

rullzer Mar 16, 2015

Choose a reason for hiding this comment

rullzer commented Mar 16, 2015

DeepDiver1975 commented Mar 30, 2015

jancborchardt commented Jun 29, 2015

nickvergessen commented Jun 30, 2015

rullzer commented Jul 1, 2015

rullzer commented Jul 21, 2015

nickvergessen Jul 22, 2015

Choose a reason for hiding this comment

rullzer Jul 22, 2015

Choose a reason for hiding this comment

LukasReschke commented Jul 27, 2015

rullzer commented Jul 27, 2015

rullzer commented Jul 28, 2015

rullzer commented Aug 6, 2015

LukasReschke Aug 10, 2015

Choose a reason for hiding this comment

rullzer Aug 10, 2015

Choose a reason for hiding this comment

LukasReschke commented Aug 10, 2015

DeepDiver1975 commented Aug 10, 2015

LukasReschke commented Aug 10, 2015

DeepDiver1975 commented Aug 10, 2015

DeepDiver1975 commented Aug 10, 2015

rullzer commented Aug 19, 2015

rullzer commented Aug 29, 2015

MorrisJobke commented Aug 29, 2015

scrutinizer-notifier commented Aug 29, 2015

ghost commented Aug 29, 2015

MorrisJobke commented Aug 29, 2015

DeepDiver1975 commented Sep 15, 2015

tobiasKaminsky commented Feb 10, 2016

lock bot commented Aug 7, 2019