Ocs respect enforced date #15025
Merged
Ocs respect enforced date #15025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that we do not allow removing of the expiration date when this is enforced in the settings.
Tests added to make sure that removing an expire date when this is enforced is not allowed.
|
Refer to this link for build results (access rights to CI server needed): |
|
The inspection completed: 2 new issues, 2 updated code elements |
|
makes sense 👍 |
|
👍 |
|
I just checked and the bug is also there (at least on stable8). Should this be backported? |
DeepDiver1975
added a commit
that referenced
this pull request
Mar 19, 2015
Ocs respect enforced date
yes - please - thx |
PVince81
pushed a commit
that referenced
this pull request
Mar 26, 2015
[stable8] Backport of #15025: OCS Respect enforced date
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #15021
If the expiration date is enforced it should not be possible to delete it.
Of course new tests are added.