Storage 503 message improvements

[PVince81]

Description

"Storage not available" is now "Storage temporarily not available".
Exceptions are now logged in DEBUG level, not FATAL.

Related Issue

For #25854 (comment)

Motivation and Context

See #25854 (comment)

How Has This Been Tested?

Setup a federated share.
Set the source share server to maintenance mode.
Try accessing the received federated share.

• TEST: Check the log that the log level is DEBUG for StorageNotAvailableException
• TEST: UI message says "Storage is temporarily not available" now
• TEST: Webdav response message also says says "Storage is temporarily not available"

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

@owncloud/filesystem @mmattel

[PVince81]

Hmm, it still logs a fatal, checking...

[butonic]

hm, the smb storage throws StorageNotAvailableExceptions all over the place: https://github.com/owncloud/core/blob/master/apps/files_external/lib/Lib/Storage/SMB.php#L47

[PVince81]

@butonic hmm, indeed. Not sure if the message "Storage temporarily available" is adequate in these case. If we do want it, maybe need to rethrow another StorageNotAvailableException and wrap the SMB one in "$previous".

[PVince81]

this change here was in the context of unavailable federated shares

[PVince81]

Can we still merge this even if it cannot cover all possible cases ?

[mmattel]

For me ok, agreed - better this than nothing 👍

[guruz]

In the client we have

src/libsync/discoveryphase.cpp:        if (reason == "Storage not available") {

Will adjust..

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.