-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove skipMigrations, fix app info use-migration code #27982
Conversation
works! 👍 |
for customgroups pleae check the DB that oc_customgroup* tables are created after install |
Would be good to also test app update with the same matrix items. Maybe reduce version in oc_appconfig to trigger an update |
customgroup tables are created |
Confirmed this fixes cli install for ldap and customgroups |
Testing upgrade from 9.1... |
Upgrade from 9.1 to 10.0.1+patch went smoothly with ldap installed/enabled in 9.1 |
👍 Tested installations via WebUI , CLI and upgrade from 9.1.5 and LDAP went fine |
Thanks. Let's merge after CI |
Rebased because CI shat his pants |
now it's Travis who shat his pants... |
I restarted the chrome UI test job that failed with "stale element reference: element is not attached to the page document". @individual-it is currently looking at how to make those tests more robust to avoid seemingly-random stuff that can happen when pages are in transition states. |
Jenkins crapped itself and fell apart, job failed too: https://jenkins.owncloud.org/job/owncloud-core/job/core/job/PR-27982/ Rebased for another try... 🎲 |
all test passed, WTF? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Please test asap @butonic @owncloud/qa
Test matrix:
combined with: