Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skipMigrations, fix app info use-migration code #27982

Merged
merged 1 commit into from May 24, 2017
Merged

Conversation

PVince81
Copy link
Contributor

Please test asap @butonic @owncloud/qa

Test matrix:

  • CLI market:install with local package
  • CLI market:install with remote package
  • web UI install
  • occ upgrade

combined with:

  • app with database.xml: user_ldap
  • app with use-migrations: customgroups

@butonic
Copy link
Member

butonic commented May 23, 2017

works! 👍

@PVince81
Copy link
Contributor Author

for customgroups pleae check the DB that oc_customgroup* tables are created after install

@PVince81
Copy link
Contributor Author

Would be good to also test app update with the same matrix items. Maybe reduce version in oc_appconfig to trigger an update

@butonic
Copy link
Member

butonic commented May 23, 2017

customgroup tables are created

@tomneedham
Copy link
Member

Confirmed this fixes cli install for ldap and customgroups

@tomneedham
Copy link
Member

Testing upgrade from 9.1...

@tomneedham
Copy link
Member

Upgrade from 9.1 to 10.0.1+patch went smoothly with ldap installed/enabled in 9.1

@davitol
Copy link
Contributor

davitol commented May 23, 2017

👍 Tested installations via WebUI , CLI and upgrade from 9.1.5 and LDAP went fine

@butonic butonic added this to the 10.0.2 milestone May 23, 2017
@butonic butonic added Type:Bug p1-urgent Critical issue, need to consider hotfix with just that issue labels May 23, 2017
@PVince81
Copy link
Contributor Author

Thanks. Let's merge after CI

@PVince81
Copy link
Contributor Author

Rebased because CI shat his pants

@PVince81
Copy link
Contributor Author

now it's Travis who shat his pants...

@phil-davis
Copy link
Contributor

phil-davis commented May 24, 2017

I restarted the chrome UI test job that failed with "stale element reference: element is not attached to the page document". @individual-it is currently looking at how to make those tests more robust to avoid seemingly-random stuff that can happen when pages are in transition states.

@PVince81
Copy link
Contributor Author

Jenkins crapped itself and fell apart, job failed too: https://jenkins.owncloud.org/job/owncloud-core/job/core/job/PR-27982/

Rebased for another try... 🎲

@butonic
Copy link
Member

butonic commented May 24, 2017

all test passed, WTF?

@davitol davitol merged commit 23e7e0f into master May 24, 2017
@davitol davitol deleted the market-bullshit branch May 24, 2017 18:59
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - To release p1-urgent Critical issue, need to consider hotfix with just that issue Type:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants