New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skipMigrations, fix app info use-migration code #27982

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
5 participants
@PVince81
Member

PVince81 commented May 23, 2017

Please test asap @butonic @owncloud/qa

Test matrix:

  • CLI market:install with local package
  • CLI market:install with remote package
  • web UI install
  • occ upgrade

combined with:

  • app with database.xml: user_ldap
  • app with use-migrations: customgroups
@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic May 23, 2017

Member

works! 👍

Member

butonic commented May 23, 2017

works! 👍

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 23, 2017

Member

for customgroups pleae check the DB that oc_customgroup* tables are created after install

Member

PVince81 commented May 23, 2017

for customgroups pleae check the DB that oc_customgroup* tables are created after install

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 23, 2017

Member

Would be good to also test app update with the same matrix items. Maybe reduce version in oc_appconfig to trigger an update

Member

PVince81 commented May 23, 2017

Would be good to also test app update with the same matrix items. Maybe reduce version in oc_appconfig to trigger an update

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic May 23, 2017

Member

customgroup tables are created

Member

butonic commented May 23, 2017

customgroup tables are created

@tomneedham

This comment has been minimized.

Show comment
Hide comment
@tomneedham

tomneedham May 23, 2017

Member

Confirmed this fixes cli install for ldap and customgroups

Member

tomneedham commented May 23, 2017

Confirmed this fixes cli install for ldap and customgroups

@tomneedham

This comment has been minimized.

Show comment
Hide comment
@tomneedham

tomneedham May 23, 2017

Member

Testing upgrade from 9.1...

Member

tomneedham commented May 23, 2017

Testing upgrade from 9.1...

@tomneedham

This comment has been minimized.

Show comment
Hide comment
@tomneedham

tomneedham May 23, 2017

Member

Upgrade from 9.1 to 10.0.1+patch went smoothly with ldap installed/enabled in 9.1

Member

tomneedham commented May 23, 2017

Upgrade from 9.1 to 10.0.1+patch went smoothly with ldap installed/enabled in 9.1

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol May 23, 2017

Contributor

👍 Tested installations via WebUI , CLI and upgrade from 9.1.5 and LDAP went fine

Contributor

davitol commented May 23, 2017

👍 Tested installations via WebUI , CLI and upgrade from 9.1.5 and LDAP went fine

@butonic butonic added this to the 10.0.2 milestone May 23, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 23, 2017

Member

Thanks. Let's merge after CI

Member

PVince81 commented May 23, 2017

Thanks. Let's merge after CI

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 24, 2017

Member

Rebased because CI shat his pants

Member

PVince81 commented May 24, 2017

Rebased because CI shat his pants

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 24, 2017

Member

now it's Travis who shat his pants...

Member

PVince81 commented May 24, 2017

now it's Travis who shat his pants...

@phil-davis

This comment has been minimized.

Show comment
Hide comment
@phil-davis

phil-davis May 24, 2017

Contributor

I restarted the chrome UI test job that failed with "stale element reference: element is not attached to the page document". @individual-it is currently looking at how to make those tests more robust to avoid seemingly-random stuff that can happen when pages are in transition states.

Contributor

phil-davis commented May 24, 2017

I restarted the chrome UI test job that failed with "stale element reference: element is not attached to the page document". @individual-it is currently looking at how to make those tests more robust to avoid seemingly-random stuff that can happen when pages are in transition states.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 24, 2017

Member

Jenkins crapped itself and fell apart, job failed too: https://jenkins.owncloud.org/job/owncloud-core/job/core/job/PR-27982/

Rebased for another try... 🎲

Member

PVince81 commented May 24, 2017

Jenkins crapped itself and fell apart, job failed too: https://jenkins.owncloud.org/job/owncloud-core/job/core/job/PR-27982/

Rebased for another try... 🎲

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic May 24, 2017

Member

all test passed, WTF?

Member

butonic commented May 24, 2017

all test passed, WTF?

@davitol davitol merged commit 23e7e0f into master May 24, 2017

4 checks passed

Scrutinizer 1 new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@davitol davitol deleted the market-bullshit branch May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment