Dont reset displayname to uid on sso login

[tomneedham]

Description

If you login with SSO your displayname is set to your uid. Metadata sync is handled at the moment via shibboleth but will eventually be handled by the sync service on login. This is not necessary.

Related Issue

Motivation and Context

Breaks sso dispalynames

How Has This Been Tested?

• setup ldap user backend with a server (use a custom internal user id)
• use a custom displayname attribute
• sync the users
• displaynamse are correct
• setup shibboleth login
• login using sso
• see that dispalyname is still correct and is no longer converted to your uid

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #29981 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #29981      +/-   ##
============================================
+ Coverage     58.21%   58.22%   +<.01%     
  Complexity    18508    18508              
============================================
  Files          1093     1093              
  Lines         63693    63692       -1     
============================================
  Hits          37082    37082              
+ Misses        26611    26610       -1

Impacted Files	Coverage Δ	Complexity Δ
drone/src/lib/private/legacy/user.php	20.61% <0%> (+0.1%)	75% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de71a31...10e2bce. Read the comment docs.

[butonic]

yes, makes sense. if no displayname is set the fallback is the userid anyway

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.