Do not set the password again if it hasn't changed

[jvillafanez]

Description

Do not set the password again in case the permissions has changed.

Steps (copied from central)

1. share a folder with owncloud
2. choose public links
3. create new link setting a password for read only
4. Now check the modify permission

Expected

Password-protected link still works with the password set in step 3

Actual

Password-protected link can't be access due to weird password. Password set in step 3 doesn't work.

Related Issue

Reported for 10.0.8 in https://central.owncloud.org/t/password-request-for-link-share/13342

Motivation and Context

How Has This Been Tested?

Manually tested for 10.0.8
Added unittest

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #31367 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #31367      +/-   ##
============================================
+ Coverage     62.61%   62.61%   +<.01%     
- Complexity    18273    18274       +1     
============================================
  Files          1147     1147              
  Lines         68627    68627              
  Branches       1234     1234              
============================================
+ Hits          42971    42972       +1     
+ Misses        25295    25294       -1     
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	52.05% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.81% <100%> (ø)	18274 <0> (+1)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share20/Manager.php	97.25% <100%> (+0.17%)	214 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b082ab6...f489e87. Read the comment docs.

[jvillafanez]

Backport in #31370

[patrickjahns]

@jvillafanez
please provide a digest for the test information either in a github ticket or in the PR - when testing the changelog it is a mess if you have to read through a central post to determine if it works as desired

[patrickjahns]

Missing test steps

[jvillafanez]

Added unittest and include steps in the PR.

[jvillafanez]

Rebased to fix conflicts

[PVince81]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[PVince81]

Code looks fine 👍

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[phil-davis]

Backport happened - removing backport-request label

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.