Cache: mount user mountpoints to make sure that $data/$user/ exists before accessi... #3141
Conversation
|
can you fix the unittests? |
|
Yes I will check what is going on there. |
…nts will access to productive location
|
I needed to adjust the test, because via initMountPoint the real datadir would be used. Now, for time tests are running it is set to a temporary location. Tests work with and without the first commit of this pull request. Admittedly, If testing somehow breaks, the real datadir setting might be stuck with the temporary location, which would be bad. Is there a better way around it? I also have a test in preparation that checks for the bug, but before i add it i'd like to know whether this approach is ok? |
|
comments? @bartv2 @icewind1991 |
|
or others @DeepDiver1975 @tanghus @karlitschek |
|
👍 |
|
thx. One more? |
|
I'm not really happy with changes like these to the config, maybe use #3270 or @icewind1991 do you have an better idea |
|
Understandably, OTOH is #3270 supposed to end up in stable5? |
|
ok didn't see that this was for stable5 |
Cache: mount user mountpoints to make sure that $data/$user/ exists before accessi...
|
thx, I port it to master. The tests can be adjusted when the OC_Config changes are in place. |
...ng it. Fixes #2553 and #2374
review please @bartv2 @schiesbn @icewind1991 @MTGap or others