Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control of acceptance tests by more env vars #32445

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 27, 2018

Description

Instead of hard-coded defaults, if a parameter is already specified as an environment variable, then use that value.

Related Issue

owncloud/QA#582

Motivation and Context

In order to control the behavior of acceptance tests, as well as the current command parameters to run.sh we should be able to set environment variables externally. This will help when implementing things like make test-acceptance-api in make files. Developers and scripts can then easily specify needed environment variables on the end of the make command.

How Has This Been Tested?

Local runs of acceptance tests specifying various combinations of external environment variables.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #32445 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32445   +/-   ##
=========================================
  Coverage     64.06%   64.06%           
  Complexity    18634    18634           
=========================================
  Files          1176     1176           
  Lines         70142    70142           
  Branches       1267     1267           
=========================================
  Hits          44934    44934           
  Misses        24838    24838           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.33% <ø> (ø) 18634 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caed2fe...83e6e6d. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Backport stable10 #32449

@lock lock bot locked as resolved and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants