Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create local_storage files on the server #32781

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

phil-davis
Copy link
Contributor

Description

Modify acceptance test steps that create files in "local_storage" to use the testing app to create the files.

Related Issue

Motivation and Context

There is acceptance test code that still creates files in the local filesystem and expects them to "appear" in the server file system. We do not want to assume this works any more.

How Has This Been Tested?

Local runs of affected acceptance tests e.g.:

./tests/acceptance/run.sh tests/acceptance/features/apiMain/checksums.feature:73

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis force-pushed the create-local_storage-files-on-server branch from 549d47b to e80e3e3 Compare September 20, 2018 15:13
@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #32781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32781   +/-   ##
=========================================
  Coverage     64.14%   64.14%           
  Complexity    18681    18681           
=========================================
  Files          1177     1177           
  Lines         70284    70284           
  Branches       1270     1270           
=========================================
  Hits          45085    45085           
  Misses        24829    24829           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.42% <ø> (ø) 18681 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5990139...db4608a. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Backport stable10 #32784

@phil-davis phil-davis merged commit f2bf7fa into master Sep 20, 2018
@phil-davis phil-davis deleted the create-local_storage-files-on-server branch September 20, 2018 16:03
@lock lock bot locked as resolved and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants