Add creating user to a service class #32857

sharidas · 2018-09-26T06:04:24Z

Moving creation of user to a service class.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Add the create user to a service class. It is moved from user_management apps UsersController.

Related Issue

Fixes <issue_link>

Motivation and Context

Add the create user to a service class. It is moved from user_management apps UsersController. This will help us in integrating the change with the user:add command support creating users with username and email address.

How Has This Been Tested?

...

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:
Requires user_management PR Move the user create change to core owncloud-archive/user_management#75 , password_policy PR Replace generic event with custom event for password generation password_policy#154

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

codecov · 2018-09-26T06:20:34Z

Codecov Report

Merging #32857 into master will decrease coverage by 16.17%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #32857       +/-   ##
=============================================
- Coverage     64.06%   47.88%   -16.18%     
=============================================
  Files          1190      109     -1081     
  Lines         69047    10448    -58599     
  Branches       1271     1271               
=============================================
- Hits          44234     5003    -39231     
+ Misses        24443     5075    -19368     
  Partials        370      370

Flag	Coverage Δ	Complexity Δ
#javascript	`52.88% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`36.91% <ø> (-28.45%)`	`0 <ø> (-18276)`

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	`59.45% <0%> (-21.64%)`	`0% <0%> (ø)`
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1066 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a81eb...2c8c0b5. Read the comment docs.

sharidas · 2018-09-27T10:42:35Z

Ouch.. When I run the unit test individually, I don't get failure. Will re-check again and try to fix this.

jvillafanez · 2018-10-01T10:08:19Z

lib/private/User/Service/SigninWithEmail.php

+	 * @param IAvatarManager $avatarManager
+	 * @param EventDispatcherInterface $eventDispatcher
+	 */
+	public function __construct(IUserSession $userSession, IGroupManager $groupManager,


Having 14 dependencies in a class is a sympton of things made wrong. Is the class really that complex, or maybe the class can be splitted in two or more?

jvillafanez · 2018-10-01T10:11:19Z

lib/private/User/Service/SigninWithEmail.php

+	 */
+	public function create($username, $password, array $groups= [], $email='') {
+		if ($email !== '' && !$this->mailer->validateMailAddress($email)) {
+			return new DataResponse(


A service implies that the code will be executed deep down the architecture, as such it shouldn't care about DataResponse nor translations because it will be handled somewhere on top (in a controller, command, or similar)

jvillafanez · 2018-10-01T10:59:45Z

lib/private/User/Service/SigninWithEmail.php

+		$this->appManager = $appManager;
+		$this->avatarManager = $avatarManager;
+		$this->eventDispatcher = $eventDispatcher;
+		$this->isAdmin = $this->isAdmin();


I'd rather move these checks out and leave only injected objects in the constructor. Moving them out should help with the tests because other methods should use the private isAdmin() method call instead of an attribute set here.
Consider to use caching if the check is heavy, but caching should be provided by the method.

jvillafanez · 2018-10-01T11:04:12Z

lib/private/User/Service/SigninWithEmail.php

+	}
+
+	/**
+	 * @param $username


missing type hint

jvillafanez · 2018-10-01T11:06:16Z

lib/private/User/Service/SigninWithEmail.php

+					$password = $this->secureRandom->generate(20);
+				}
+			}
+			$user = $this->userManager->createUser($username, $password);


If both password and email are empty, we still try to create the user with username and password. It seems wrong.

jvillafanez · 2018-10-01T11:23:01Z

lib/private/User/Service/SigninWithEmail.php

+			);
+		}
+
+		if ($user instanceof User) {


I'd prefer to use if ($user !== false). In fact, I'd rather have a if ($user === false) and include the error code there. We expect the user to be created.

jvillafanez · 2018-10-01T11:25:49Z

lib/private/User/Service/SigninWithEmail.php

+
+	/**
+	 * @param string $userId
+	 * @param string $email


missing @throws \Exception (specially for a public method)

jvillafanez · 2018-10-01T11:34:05Z

lib/private/User/Service/SigninWithEmail.php

+			return $this->groupManager->isAdmin($activeUser->getUID());
+		}
+		// Check if it is triggered from command line
+		if (\OC::$CLI) {


Any chance to avoid this check? The service should work the same regardless of being executed by cli or not, plus this should be covered by unittests.

jvillafanez · 2018-10-01T11:37:30Z

lib/private/User/Service/SigninWithEmail.php

+	 * @param array $userGroups
+	 * @return array
+	 */
+	public function formatUserForIndex(IUser $user, array $userGroups = null) {


Why this method is public when it's only called inside this class? Either make it private or include a comment explaining the expected scenarios where this method will be called from other classes.

jvillafanez · 2018-10-01T11:47:33Z

lib/private/User/Service/SigninWithEmail.php

+			try {
+				$avatarAvailable = $this->avatarManager->getAvatar($user->getUID())->exists();
+			} catch (\Exception $e) {
+				//No avatar yet


Log something here, even if it's just a debug message. If something goes wrong getting the avatar, this will be impossible to detect, debug and fix. Note that you're catching any exception even the NobodyExpectsTheSpanishInquisitionException that could happen uploading such file as avatar (it's a joke, but ilustrates why it's a bad idea swallowing exceptions like this)

jvillafanez · 2018-10-01T11:58:03Z

I've just checked the SigninWithEmail class, not everything. I expect some changes that might affect the rest of the code.

jvillafanez · 2018-10-08T09:03:54Z

lib/private/User/Service/CreateUser.php

+				 * use one time. The new user has to reset it using the link
+				 * from email.
+				 */
+				$event = new GenericEvent();


Any chance of using a custom event instead of a generic one? A custom event would be better because it can have a specific method to set the password we want to use, as well as document what exceptions are allowed to be thown from the event handler, if any.

Added a new custom event. Let me know if this looks ok. As part of this change I made modification to password_policy app. Hence owncloud/password_policy#154, needs review too.

jvillafanez · 2018-10-08T09:05:19Z

lib/private/User/Service/CreateUser.php

+			throw new CannotCreateUserException($message);
+		}
+
+		if ($user instanceof User) {


It might be better to reverse the logic:

if ($user === null) { throw new CannotCreateUserException(....); }

Updated as per the suggestion.

jvillafanez · 2018-10-08T09:05:56Z

lib/private/User/Service/CreateUser.php

+			return $this->groupManager->isAdmin($activeUser->getUID());
+		}
+		// Check if it is triggered from command line
+		if (\OC::$CLI) {


any chance not to depend on this static variable?

Removed the dependency with the static variable.

jvillafanez · 2018-10-09T08:24:19Z

lib/private/User/Service/CreateUser.php

+				 * use one time. The new user has to reset it using the link
+				 * from email.
+				 */
+				$passwordCreateEvent = new UserPasswordCreateEvent(UserPasswordCreateEvent::CREATE_PASSWORD, []);


We have to keep backwards compatibility. I don't think we have a migration path for these events yet, so it's better not to touch it.
My point is that we can't assume that the app will be updated, or even use the new event. The apps need to work anyway. If the app is still using the old GenericEvent it will likely crash.

The idea is fine, but the old event still needs to be thrown. Maybe @PVince81 can decide how and when we want to move this forward.

I have reverted the code and brought back the GenericEvent.

jvillafanez · 2018-10-09T08:30:34Z

lib/private/User/Service/CreateUser.php

+			return $this->groupManager->isAdmin($activeUser->getUID());
+		}
+		// Check if it is triggered from command line
+		$cli = \in_array(\php_sapi_name(), ['cli']);


The point of touching this was to make unittests easier. Even though the tests should mainly test public methods, all the code in the class should be covered by those unittests. Right now, this isn't possible because the php_sapi_name can't be mocked, which means that this method will never return false, and the corresponding code path won't be covered by unittests.

If you can't find a better solution, use the previous code (using the OC::$CLI) because we can change it inside the tests.

I have moved php_sapi_name to a method so that it can be mocked.

jvillafanez · 2018-10-24T07:57:30Z

apps/provisioning_api/lib/Users.php

@@ -156,13 +164,27 @@ public function addUser() {
 		}

 		try {
-			$newUser = $this->userManager->createUser($userId, $password);
-			$this->logger->info('Successful addUser call with userid: '.$userId, ['app' => 'ocs_api']);
+			$password = ($password === null) ? '' : $password;


this can be done above, as part of the initialization (where all the isset($_POST[...]) are)

jvillafanez · 2018-10-24T08:04:42Z

lib/private/User/Service/CreateUserService.php

+	 * @param string $username
+	 * @param string $password can be empty string, else string for password
+	 * @param string $email
+	 * @return bool|\OCP\IUser when user is created else false


I still don't know when the boolean value is returned. You're either returning the created user object or throwing an exception. If the created user object is false, you're also throwing an exception.

Updated the doc.

jvillafanez · 2018-10-24T08:06:17Z

apps/provisioning_api/lib/Users.php

+			$userAddedToGroups = ($groups === null) ? [null] : $groups;
+			$user = $this->createUserService->createUser($userId, $password, $emailAddress);
+			if ($user instanceof User) {
+				$newUser = $this->userManager->get($userId);


This seems pointless. You should already have the instance from the createUser call.

jvillafanez · 2018-10-24T08:21:23Z

lib/private/User/Service/CreateUserService.php

+	}
+
+	/**
+	 * Add user to the groups


Just reading this I assume that, if for whatever reason the user can't be added to a group (It's an LDAP group, or there is a problem saving the data), the function will return false. This isn't true because the function will return true as long as the user is added to just one group.
There is also no clarification about what happens if the user isn't added to a group: should the code ignore it? should remove the assignment to previous groups and abort?

Clarify the expected behaviour and fix whatever is needed.

Updated the doc. Let me know if this sounds reasonable.

jvillafanez · 2018-10-24T08:24:31Z

apps/provisioning_api/lib/Users.php


 			if (\is_array($groups)) {
+				$result = $this->createUserService->addUserToGroups($user, $userAddedToGroups);
+				if ($result === false) {
+					$this->logger->error("User $userId could not be added to groups");


It might be nice to know what are those groups

With the latest change, the user should be able to know about the groups which are not added.

jvillafanez · 2018-10-24T09:19:15Z

core/Command/User/Add.php

+			}
+		} else {
+			$output->writeln("<error>Interactive input or --password-from-env is needed for entering a password!</error>");
+			return 1;


Try to return different values for each error type. This will help to identify what happened if these commands are used in a script.

Returning different values.

jvillafanez · 2018-10-24T09:21:00Z

core/routes.php

+		['name' => 'user#setPassword', 'url' => '/setpassword/{token}/{userId}', 'verb' => 'POST'],
+		['name' => 'user#resendToken', 'url' => '/resend/token/{userId}', 'verb' => 'POST'],
+		['name' => 'user#setPasswordForm', 'url' => '/setpassword/form/{token}/{userId}', 'verb' => 'GET'],
+		['name' => 'avatar#getAvatar', 'url' => '/avatar/{userId}/{size}', 'verb' => 'GET'],


where this come from?

jvillafanez · 2018-10-24T09:27:04Z

lib/private/User/Service/CreateUserService.php

+	public function addUserToGroups(IUser $user, array $groups= []) {
+		$currentUser = $this->userSession->getUser();
+		if (!$this->isAdmin($currentUser)) {
+			if (!empty($groups)) {


You might want to add a comment to explain what you're doing here, or extract this piece to another function. The code seems big, and I'm pretty sure you aren't add users to groups here.
It's fine to have some setup or preparation, but if it's too big it might be confusing.

Moved to a different method.

jvillafanez · 2018-10-24T10:03:24Z

lib/private/User/Service/CreateUserService.php

+			if (!empty($groups)) {
+				foreach ($groups as $key => $group) {
+					$groupObject = $this->groupManager->get($group);
+					if ($groupObject === null) {


if ($groupObject === null || !$this->isSubadminOfGroup($currentUser, $groupObject))

In fact, you can move the check for null inside the isSubadminOfGroup function to simplify this piece.

jvillafanez · 2018-10-24T10:04:51Z

lib/private/User/Service/CreateUserService.php

+			return $this->groupManager->isAdmin($currentUser->getUID());
+		}
+		// Check if it is triggered from command line
+		$cli = \OC::$CLI;


just return \OC::$CLI. It's more straightforward

jvillafanez · 2018-10-24T14:29:13Z

apps/provisioning_api/lib/Users.php

 		$user = $this->userSession->getUser();
 		$isAdmin = $this->groupManager->isAdmin($user->getUID());
 		$subAdminManager = $this->groupManager->getSubAdmin();
+		$password = ($password === null) ? '' : $password;


move it upper, line 135. Initialize the same way you're doing with the emailAddress.

jvillafanez · 2018-10-24T14:30:55Z

apps/provisioning_api/lib/Users.php

@@ -156,13 +165,28 @@ public function addUser() {
 		}

 		try {
-			$newUser = $this->userManager->createUser($userId, $password);
-			$this->logger->info('Successful addUser call with userid: '.$userId, ['app' => 'ocs_api']);
+			$groups = ($groups === null) ? [null] : $groups;


is this needed? any more clear way to do it?

jvillafanez · 2018-10-24T14:32:18Z

apps/provisioning_api/lib/Users.php

-			$this->logger->info('Successful addUser call with userid: '.$userId, ['app' => 'ocs_api']);
+			$groups = ($groups === null) ? [null] : $groups;
+			$newUser = $this->createUserService->createUser($userId, $password, $emailAddress);
+			if ($newUser instanceof User) {


This check doesn't seem to be needed.

jvillafanez · 2018-10-24T14:38:14Z

lib/private/User/Service/CreateUserService.php

+	 *
+	 * @param IUser $user
+	 * @param array $groups contains array of group names
+	 * @return array with bool, true if user is added to groups, else false, and array of groups failed to add user


It's better to return just the list of groups that weren't added. We can assume that if the returned list is empty, the user has been added to all the groups correctly.

jvillafanez · 2018-10-24T14:45:41Z

apps/provisioning_api/lib/Users.php

+				if ($result === false) {
+					$failedGroups = \implode(',', $failedGroups);
+					$this->logger->error("User $userId could not be added to groups " . $failedGroups);
+				}
 				foreach ($groups as $group) {


this seems to be duplicated. The user should have been added to the groups with the addUserToGroups

jvillafanez · 2018-10-24T16:10:31Z

core/Command/User/Add.php

+					return 7;
+				} else {
+					foreach ($groupInput as $groupName) {
+						if ($this->groupManager->isInGroup($uid, $groupName)) {


Knowing the groups that have failed, you should know what are the ones that succeeded, no need to ask the groupManager.

jvillafanez · 2018-10-24T16:15:05Z

lib/private/User/Service/CreateUserService.php

+	 * @param array $groups contains group names
+	 * @return array
+	 */
+	private function setUpGroupsForUser(IUser $currentUser, $groups) {


I don't think the name reflects what the function does. I don't get what this function is for.... assuming that the currentUser is a subadmin, make sure the $groups fall into the groups controlled by the subadmin? If this is it, we might need to have a look at this because this seems quite complex for that.

jvillafanez · 2018-10-24T16:16:52Z

lib/private/User/Service/CreateUserService.php

+	 *
+	 * @param IUser $user
+	 * @param array $groups contains array of group names
+	 * @return array with bool, true if user is added to groups or if no groups are there, else false, and array of groups failed to add user


if feels better if you just return the list of failed groups. If the list is empty, the user has been added to all the groups, so no need to return the boolean.

jvillafanez · 2018-10-24T16:20:48Z

lib/private/User/Service/CreateUserService.php

+		$userAddedToGroup = false;
+		if (\count($groups) >= 1) {
+			foreach ($groups as $groupName) {
+				if ($groupName !== null) {


Any reason to check for null here? I expect the list not to contain any null, otherwise we'll likely be doing something wrong somewhere.

This null check comes from https://github.com/owncloud/core/pull/32857/files#r227814464

jvillafanez · 2018-10-24T16:23:30Z

lib/private/User/Service/CreateUserService.php

+					if (empty($groupObject)) {
+						$groupObject = $this->groupManager->createGroup($groupName);
+					}
+					$groupObject->addUser($user);


I think the addUser doesn't return anything, so we don't know whether the user has been effectively added to the group or not (it doesn't throw any "known" exception as far as I know). It might be interesting to add a parameter to indicate whether we should explicitly check here if the user has been added or not.

CLAassistant · 2018-10-25T05:15:24Z

All committers have signed the CLA.

Moving creation of user to a service class. Signed-off-by: Sujith H <sharidasan@owncloud.com>

jvillafanez · 2018-10-26T06:54:42Z

apps/provisioning_api/lib/Users.php

@@ -126,7 +133,9 @@ public function getUsers() {
 	public function addUser() {
 		$userId = isset($_POST['userid']) ? $_POST['userid'] : null;
 		$password = isset($_POST['password']) ? $_POST['password'] : null;
+		$password = ($password === null) ? '' : $password;


This isn't needed.

$password = isset($_POST['password']) ? $_POST['password'] : ''

jvillafanez · 2018-10-26T06:55:49Z

apps/provisioning_api/lib/Users.php

@@ -156,13 +165,15 @@ public function addUser() {
 		}

 		try {
-			$newUser = $this->userManager->createUser($userId, $password);
+			$groups = ($groups === null) ? [] : $groups;


Move this above, as part of the initiailization. Also do the same as with the password. Also make sure the variable is always an array.

jvillafanez · 2018-10-26T07:01:11Z

apps/provisioning_api/lib/Users.php

@@ -156,13 +165,15 @@ public function addUser() {
 		}

 		try {
-			$newUser = $this->userManager->createUser($userId, $password);
+			$groups = ($groups === null) ? [] : $groups;
+			$newUser = $this->createUserService->createUser($userId, $password, $emailAddress);
 			$this->logger->info('Successful addUser call with userid: '.$userId, ['app' => 'ocs_api']);

 			if (\is_array($groups)) {


we should try to remove this check by making sure this will always be an array.

Removed the check. And one round of manual testing it was working. Will re-check again.

jvillafanez · 2018-10-26T07:28:19Z

core/Command/User/Add.php

+				$failedGroups = $this->createUserService->addUserToGroups($newUser, $groupInput);
+				if (\count($failedGroups) > 0) {
+					$failedGroups = \implode(',', $failedGroups);
+					$output->writeln('<warning>Unable to add user: ' . $uid . ' to groups ' . $failedGroups . '.</warning>');


try to use string interpolation as much as possible.

Mostly done. Need to re-check again.

jvillafanez · 2018-10-26T07:32:04Z

core/Command/User/Add.php

+					return 7;
+				} else {
+					foreach ($groupInput as $groupName) {
+						if ($this->groupManager->isInGroup($uid, $groupName)) {


This check is already done in the addUserToGroups, no need to duplicate.

jvillafanez · 2018-10-26T07:36:27Z

core/Command/User/Add.php

-			// init some group shares.
-			Filesystem::init($user->getUID(), '');
-		}
+			$newUser = $this->createUserService->createUser($uid, $password, $email);


double-check if there is any difference with the code added above. Move the code to a private function if possible to avoid the duplication.

I will update this change.

jvillafanez · 2018-10-26T07:41:17Z

lib/private/User/Service/CreateUserService.php

+	public function addUserToGroups(IUser $user, array $groups= [], $checkInGroup = true) {
+		$failedToAdd = [];
+
+		if (\count($groups) >= 1) {


This shouldn't be needed. The loop won't be executed if the array is empty.

jvillafanez · 2018-10-26T07:42:58Z

lib/private/User/Service/CreateUserService.php

+
+		if (\count($groups) >= 1) {
+			foreach ($groups as $groupName) {
+				if ($groupName !== '') {


any reason for this check?

jvillafanez · 2018-10-26T07:49:21Z

lib/private/User/Service/CreateUserService.php

+					if ($checkInGroup && !$this->groupManager->isInGroup($user->getUID(), $groupName)) {
+						$failedToAdd[] = $groupName;
+					} else {
+						$this->logger->info('Added userid ' . $user->getUID() . ' to group ' . $groupObject->getGID());


I'd prefer to remove this log because it might be inaccurate, at least with the current code. If the checkInGroup is false, the user might be be added but we'll show a log stating that the user has been added. This will be very troublesome to debug.

Update the provisioning api for new user registration with email. Signed-off-by: Sujith H <sharidasan@owncloud.com>

DeepDiver1975 · 2019-07-19T09:08:04Z

outdated -> close

sharidas · 2019-07-19T11:41:18Z

Reopening this PR again.

micbar · 2019-07-19T18:00:15Z

@sharidas This PR seems very outdated.
We do not need UI parts, they are already done.

Wouldn't it be better to start from scratch?

DeepDiver1975 · 2019-07-30T06:19:34Z

As discussed in #35777 the master branch will from now on hold the ownCloud 10 codebase.

This PR targetted ownCloud 11 which is postponed to a far distant future.

Because of that I'm closing this PR and kindly ask you to re-submit this PR in a few days.

Thanks a lot for your patience

sharidas self-assigned this Sep 26, 2018

sharidas added the 2 - Developing label Sep 26, 2018

sharidas added this to the development milestone Sep 26, 2018

sharidas mentioned this pull request Sep 26, 2018

Move the user create change to core owncloud-archive/user_management#75

Open

sharidas force-pushed the move-createuser-toservice branch 2 times, most recently from 718bc05 to 77f025c Compare September 27, 2018 06:04

sharidas changed the title ~~[WIP] Add creating user to a service class~~ Add creating user to a service class Sep 27, 2018

sharidas assigned PVince81 and unassigned PVince81 Sep 27, 2018

sharidas requested a review from PVince81 September 27, 2018 06:10

sharidas added 3 - To Review and removed 2 - Developing labels Sep 27, 2018

sharidas force-pushed the move-createuser-toservice branch 4 times, most recently from f9bc134 to 545c763 Compare September 27, 2018 08:37

PVince81 requested a review from jvillafanez September 27, 2018 10:18

sharidas force-pushed the move-createuser-toservice branch from 545c763 to edceaa7 Compare September 28, 2018 07:41

jvillafanez reviewed Oct 1, 2018

View reviewed changes

DeepDiver1975 added 2 - Developing and removed 3 - To Review labels Oct 2, 2018

sharidas force-pushed the move-createuser-toservice branch from edceaa7 to 821cd77 Compare October 5, 2018 13:01

jvillafanez reviewed Oct 8, 2018

View reviewed changes

sharidas mentioned this pull request Oct 8, 2018

Replace generic event with custom event for password generation owncloud/password_policy#154

Closed

sharidas force-pushed the move-createuser-toservice branch from 821cd77 to 5fb16a8 Compare October 8, 2018 12:19

jvillafanez reviewed Oct 9, 2018

View reviewed changes

sharidas force-pushed the move-createuser-toservice branch from 5fb16a8 to 7036014 Compare October 16, 2018 14:47

sharidasan force-pushed the move-createuser-toservice branch 3 times, most recently from d61b730 to 1b65bab Compare October 24, 2018 07:34

jvillafanez reviewed Oct 24, 2018

View reviewed changes

sharidasan force-pushed the move-createuser-toservice branch 3 times, most recently from aded134 to a1ce6f6 Compare October 24, 2018 15:42

jvillafanez reviewed Oct 24, 2018

View reviewed changes

sharidasan force-pushed the move-createuser-toservice branch from a1ce6f6 to 0307c4b Compare October 25, 2018 05:15

sharidasan force-pushed the move-createuser-toservice branch 5 times, most recently from ca3a5bd to 4791191 Compare October 25, 2018 17:08

Add creating user to a service class

cb857c0

Moving creation of user to a service class. Signed-off-by: Sujith H <sharidasan@owncloud.com>

jvillafanez reviewed Oct 26, 2018

View reviewed changes

Update provisioning api for new user registration with email

2c8c0b5

Update the provisioning api for new user registration with email. Signed-off-by: Sujith H <sharidasan@owncloud.com>

sharidasan force-pushed the move-createuser-toservice branch from 4791191 to 2c8c0b5 Compare October 26, 2018 09:39

sharidasan assigned sharidas and unassigned sharidasan Oct 31, 2018

DeepDiver1975 closed this Jul 19, 2019

DeepDiver1975 deleted the move-createuser-toservice branch July 19, 2019 09:08

sharidas restored the move-createuser-toservice branch July 19, 2019 11:40

sharidas reopened this Jul 19, 2019

DeepDiver1975 closed this Jul 30, 2019

Add creating user to a service class #32857

Add creating user to a service class #32857

Conversation

sharidas commented Sep 26, 2018 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

codecov bot commented Sep 26, 2018 • edited Loading

Codecov Report

sharidas commented Sep 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jvillafanez commented Oct 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Oct 25, 2018 • edited Loading

Choose a reason for hiding this comment

sharidasan Oct 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sharidas commented Sep 26, 2018 •

edited

Loading

codecov bot commented Sep 26, 2018 •

edited

Loading

CLAassistant commented Oct 25, 2018 •

edited

Loading

sharidasan Oct 26, 2018 •

edited

Loading