Feature/yarn stable10

[DeepDiver1975]

Description

Finally use yarn for front end dependencies in stable10 for 10.1

In order to fix files which are moved into the release tar ball a modclean pattern plugin has been developed and is applied

Versions have been used as per current stable 10 - as far as possible ..

Related Issue

• Fixes Move stable10 to yarn #33651

Motivation and Context

bower is dead - only package.json is monitored by sec tools like dependebot and snyk

How Has This Been Tested?

• ✋

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[PVince81]

👍

[codecov]

Codecov Report

Merging #33665 into stable10 will increase coverage by 1.08%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable10   #33665      +/-   ##
==============================================
+ Coverage       63.02%   64.11%   +1.08%     
- Complexity      18923    18930       +7     
==============================================
  Files            1242     1180      -62     
  Lines           74211    66966    -7245     
  Branches         1287        0    -1287     
==============================================
- Hits            46774    42935    -3839     
+ Misses          27057    24031    -3026     
+ Partials          380        0     -380

Flag	Coverage Δ	Complexity Δ
#javascript	?	?
#phpunit	64.11% <ø> (+0.01%)	18930 <ø> (+7)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
apps/encryption/templates/settings-admin.php	88.23% <0%> (-5.89%)	0% <0%> (ø)
apps/encryption/lib/Session.php	98.03% <0%> (-1.97%)	22% <0%> (ø)
core/js/oc-dialogs.js
core/js/oc-backbone.js
settings/js/admin-apps.js
core/js/config.js
apps/files_sharing/js/external.js
apps/comments/js/commentmodel.js
core/js/l10n.js
core/js/js.js
... and 56 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1ecee...5f114b1. Read the comment docs.

[PVince81]

seems now JS tests fail because PhantomJS failed to start https://drone.owncloud.com/owncloud/core/13126/72

[DeepDiver1975]

seems now JS tests fail because PhantomJS failed to start https://drone.owncloud.com/owncloud/core/13126/72

no idea what's going on ... 🤷‍♂️

[PVince81]

this introduces the owncloud basic pattern for modclean in package.json. when removing it PhantomJS starts correctly.

I found that this owncloud basic pattern is not enabled on master either, so let's address this separately.

pushing...

[PVince81]

ok, I suggest running modclean in the Makefile "dist" rule and operate on the "build/dist/owncloud" folder to make sure we don't kill some tools in the local dev env

[DeepDiver1975]

php seg fault now .... I suggest to take this as is .... if we want to go with the current approach in make dist .... @PVince81

[PVince81]

👍

[PVince81]

@DeepDiver1975 please address #33650 now