Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust yarn nodejs Makefile like stable10 33665 #34794

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Conversation

phil-davis
Copy link
Contributor

Description

Some diffs related to yarn stuff happened around the yarn backport PR #33665
The code in stable10 seems better, so forward-port it to master

Motivation and Context

Get master Makefile more like stable10

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #34794 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34794   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <ø> (ø) 18481 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c68f...790e95a. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #34794 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34794   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <ø> (ø) 18481 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c68f...790e95a. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #34794 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34794   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <ø> (ø) 18481 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898c68f...790e95a. Read the comment docs.

@phil-davis phil-davis merged commit 45978d2 into master Mar 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the yarn-core_vendor branch March 18, 2019 13:19
@DeepDiver1975
Copy link
Member

this is only a partial backport of 5f114b1

@phil-davis
Copy link
Contributor Author

Looking now - I guess that PR #33665 to stable10 did more than a straight backport of stuff from master

@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants