Keep build folder ... kills circular-json #34841
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34841 +/- ##
=========================================
Coverage 65.34% 65.34%
Complexity 18478 18478
=========================================
Files 1208 1208
Lines 69943 69943
Branches 1280 1280
=========================================
Hits 45707 45707
Misses 23864 23864
Partials 372 372
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34841 +/- ##
============================================
+ Coverage 65.34% 65.35% +<.01%
- Complexity 18478 18484 +6
============================================
Files 1208 1208
Lines 69943 69969 +26
Branches 1280 1280
============================================
+ Hits 45707 45727 +20
- Misses 23864 23870 +6
Partials 372 372
Continue to review full report at Codecov.
|
| @@ -57,6 +57,6 @@ | |||
| }, | |||
| "scripts": { | |||
| "clean-modules": "modclean -r --patterns=\"default:safe,owncloud:basic\"", | |||
| "postinstall": "node -e \"try { require('fs').symlinkSync(require('path').resolve('node_modules/@bower_components'), '../core/vendor', 'junction') } catch (e) { }\"" | |||
| "postinstall": "modclean -r --patterns=\"default:safe\" && node -e \"try { require('fs').symlinkSync(require('path').resolve('node_modules/@bower_components'), '../core/vendor', 'junction') } catch (e) { }\"" | |||
There was a problem hiding this comment.
that is different to the mentioned PR https://github.com/owncloud/core/pull/33665/files#diff-c5776441e263bb28be0b4b6e51fd527fR58
also 5f114b1
There was a problem hiding this comment.
@individual-it I updated the description to point to another commit in #34784
There is so much of this dependency stuff that was done slightly different ways and orders in master and stable10!
Forward port from stable10 PR #33665
"Keep build folder ... kills circular-json"
and
"Adding modclean to have smaller release tar balls" b84b14f - which was the reason for a diff between stable10 and master in
package.jsonpostinstallline.I missed cherry-pick of these to master in PRs #34794 and #34796
And dbe9373 gets
package.jsoninmastercloser tostable10