Fixing node components

[phil-davis]

Description

PR #34794 forward-ported yarn-related changes to Makefile from stable10 PR #33665

Those need other commits from that PR, so that make dist will know about clean-modules

Motivation and Context

How Has This Been Tested?

make clean
make dist

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[DeepDiver1975]

Looks good. THX

[phil-davis]

NP - I broke it. IMO better to try and fix it than back-out the changes.
It is a pain having code in stable10 that did not start its life in master - forward-porting seems to be often even less obvious than back-porting.

[codecov]

Codecov Report

Merging #34796 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #34796   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	53.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.71% <ø> (ø)	18481 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0de0d3...95afe93. Read the comment docs.

[codecov]

Codecov Report

Merging #34796 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #34796   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	53.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.71% <ø> (ø)	18481 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0de0d3...95afe93. Read the comment docs.

[codecov]

Codecov Report

Merging #34796 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #34796   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	53.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.71% <ø> (ø)	18481 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0de0d3...95afe93. Read the comment docs.

[codecov]

Codecov Report

Merging #34796 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #34796   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	53.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.71% <ø> (ø)	18481 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0de0d3...95afe93. Read the comment docs.

[codecov]

Codecov Report

Merging #34796 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #34796   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	53.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.71% <ø> (ø)	18481 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0de0d3...95afe93. Read the comment docs.

[codecov]

Codecov Report

Merging #34796 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #34796   +/-   ##
=========================================
  Coverage     65.31%   65.31%           
  Complexity    18481    18481           
=========================================
  Files          1209     1209           
  Lines         69983    69983           
  Branches       1280     1280           
=========================================
  Hits          45706    45706           
  Misses        23905    23905           
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	53.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.71% <ø> (ø)	18481 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0de0d3...95afe93. Read the comment docs.

[phil-davis]

@PVince81 @DeepDiver1975 or anyone who approves this. Please merge it so it gets in the QA tarball tonight.

[PVince81]

👍