-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let resharer to send an e-mail for public link #36393
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36393 +/- ##
=========================================
Coverage 64.87% 64.87%
- Complexity 19797 19798 +1
=========================================
Files 1272 1272
Lines 74748 74748
Branches 1309 1309
=========================================
Hits 48495 48495
Misses 25867 25867
Partials 386 386
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Push a changelog entry here also.
I will look at adding some extra scenarios (issue #36388 ) that will cover a couple more combinations of this.
afe1435
to
7a304fe
Compare
Changelog entry added. |
@phil-davis Should we wait for additional tests to merge? |
@karakayasemi I tried to demo it. |
@micbar I tested again, in my environment it is working as expected. We worked with BDD approach on this issue. There is an acceptance test scenario that simulates related scenario. |
Description
let resharer to send an e-mail for public link.
Related Issue
Motivation and Context
Currently, sending an e-mail when creating public links from received shares is impossible. This PR will fix this issue.
How Has This Been Tested?
Manually with issues scenario. Also, acceptance tests are ready.
Types of changes
Checklist: