LDAP: better check for emptiness, fixes #3815 #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@blizzz what about fixing this within readConfiguration() and only write the proper value into $this->config? |
|
@blizzz May be fix readConfiguration instead? core/apps/user_ldap/lib/connection.php Line 496 in 4797f9d |
|
@DeepDiver1975 considered it too, but reading is reading and validating is validating. Won't look too nice either way. @VicDeo true, but it can only happen, if the Base DN is array([0] => ''), the user and group bases would have been adjusted. Will fix it. Good catch! |
|
have a better idea for doing it in readConfiguration indeed |
|
@DeepDiver1975 @VicDeo what do you think? Lovely? |
|
👍 |
|
👍 as soon as test build is complete |
blizzz
added a commit
that referenced
this pull request
Jun 22, 2013
LDAP: better check for emptiness, fixes #3815
|
Port to master: 5387e5c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preg_split returns an array with one (empty) element, if an empty string (or null) is passed.
Reviewers please @FlorinPeter @DeepDiver1975 @bartv2 or others