Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Pin behat/gherkin because of Gherkin issue 187 #38339

Merged
merged 1 commit into from
Jan 25, 2021
Merged

[tests-only] Pin behat/gherkin because of Gherkin issue 187 #38339

merged 1 commit into from
Jan 25, 2021

Conversation

phil-davis
Copy link
Contributor

Description

Pin the version of Behat/Gherkin to avoid issue Behat/Gherkin#187

Related Issue

workaround for #38338

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jan 25, 2021
@phil-davis
Copy link
Contributor Author

Note: if Behat/Gherkin#189 gets merged and Gherkin 4.7.1 is released, then we will not need this.

@phil-davis phil-davis mentioned this pull request Jan 25, 2021
Merged
@phil-davis phil-davis mentioned this pull request Jan 25, 2021
Merged
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 1628f61 into master Jan 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the pin-behat-gherkin branch January 25, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

Assignees

@phil-davis phil-davis

Labels
3 - To Review QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @individual-it