Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc link #38860

Merged
merged 1 commit into from
Jun 16, 2021
Merged

fix doc link #38860

merged 1 commit into from
Jun 16, 2021

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 16, 2021 •
edited
Loading

Description

The link in the share dialogue on the info icon was empty. Should be https://doc.owncloud.com/server/10.7/go.php?to=user-sharing-federated

Related Issue

Motivation and Context

Was broken since 10.0.0

How Has This Been Tested?

  • manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@micbar micbar force-pushed the fix-doc-link branch 2 times, most recently from e559bc5 to 024aeea Compare June 16, 2021 15:21
@micbar micbar requested review from tbsbdr and phil-davis June 16, 2021 15:21
@micbar micbar requested a review from mmattel June 16, 2021 15:21
@owncloud owncloud deleted a comment from update-docs bot Jun 16, 2021
phil-davis
phil-davis approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works - link takes me to https://doc.owncloud.org/server/10.8/go.php?to=user-sharing-federated - which does not exist just yet, but will when 10.8 release happens.

@ownclouders
Copy link
Contributor

💥 Acceptance tests apiShareOperationsToRoot-mariadb10.2-php7.4 failed. The build is cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance tests apiShareOperationsToShares-mariadb10.2-php7.4 failed. The build is cancelled...

@phil-davis
Copy link
Contributor

This is based off an old master - I will rebase it...

tbsbdr
tbsbdr approved these changes Jun 16, 2021
View reviewed changes
Copy link

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best man. thx!

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 14ceb33 into master Jun 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-doc-link branch June 16, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbsbdr tbsbdr tbsbdr approved these changes

@phil-davis phil-davis phil-davis approved these changes

@mmattel mmattel Awaiting requested review from mmattel

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tooltip opens link
5 participants
@micbar @ownclouders @phil-davis @tbsbdr @JammingBen