-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method to get the values for multiple users to OC\Preferences #8659
Conversation
💣 Test Failed. 💣 |
/cc @icewind1991 |
Please add a unit test. |
Unit tests are obviously missing. Please add. Thx |
💣 Test Failed. 💣 |
Looks good 👍 |
* @return array Mapped values: userid => value | ||
*/ | ||
public function getValueForUsers($app, $key, $users) { | ||
if (empty($users) || !is_array($users)) return array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two lines please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
💣 Test Failed. 💣 |
hehe - unit test actually do help - right 😉 |
🚀 Test Passed. 🚀 |
The inspection completed: 4 new issues, 3 updated code elements |
🚀 Test Passed. 🚀 |
👍 |
Add a method to get the values for multiple users to OC\Preferences
@schiesbn @DeepDiver1975 @PVince81