Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a method to get the values for multiple users to OC\Preferences #8659

Merged
merged 6 commits into from
May 22, 2014
Merged

Add a method to get the values for multiple users to OC\Preferences #8659

merged 6 commits into from
May 22, 2014

Conversation

nickvergessen
Copy link
Contributor

This was referenced May 21, 2014
Merged
Closed
@ghost
Copy link

ghost commented May 21, 2014

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4898/

@nickvergessen
Copy link
Contributor Author

/cc @icewind1991

@PVince81
Copy link
Contributor

Please add a unit test.

@DeepDiver1975
Copy link
Member

Unit tests are obviously missing.  Please add. Thx

@ghost
Copy link

ghost commented May 21, 2014

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4899/

@icewind1991
Copy link
Contributor

Looks good 👍

DeepDiver1975
DeepDiver1975 reviewed May 21, 2014
View reviewed changes
lib/private/preferences.php
* @return array Mapped values: userid => value
*/
public function getValueForUsers($app, $key, $users) {
if (empty($users) || !is_array($users)) return array();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two lines please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ghost
Copy link

ghost commented May 21, 2014

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4907/

@DeepDiver1975
Copy link
Member

hehe - unit test actually do help - right 😉

@ghost
Copy link

ghost commented May 21, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4913/

@scrutinizer-notifier
Copy link

The inspection completed: 4 new issues, 3 updated code elements

@ghost
Copy link

ghost commented May 21, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4918/

@PVince81
Copy link
Contributor

👍

PVince81 pushed a commit that referenced this pull request May 22, 2014
Merge pull request #8659 from owncloud/get-preference-multiple-user
25ecd2b 
Add a method to get the values for multiple users to OC\Preferences
@PVince81 PVince81 merged commit 25ecd2b into master May 22, 2014
@PVince81 PVince81 deleted the get-preference-multiple-user branch May 22, 2014 07:59
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nickvergessen @PVince81 @DeepDiver1975 @icewind1991 @scrutinizer-notifier @vgezer @MorrisJobke