add SSL proxy support #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for a SSL proxy that handles multiple domains via host name as prefix in the request URI (https://ssl-proxy.tld/domain.tld/). As the SSL proxy is transparent for the web server the REQUEST_URI and SCRIPT_NAME need manual adjustments. This patch replace the direct use of this _SERVER variables with function calls and extend this functions to detect the proxy and to add the needed prefix. Additionally it adds a Sabre request backend with extends the Sabre_HTTP_Request to use the same functions.
|
Thanks! Just as an information for you: We're currently in the hard feature freeze for 4.5 which will last until the release of 4.5. This means that we're currently not allowed to commit new features. I'm sure someone will take a look at it, after the release of 4.5 :-) |
|
The code looks good, maybe it could be split in 2 commits. But it is fine like this, ping me after the release of 4.5 if i forgot to merge this. |
|
@herbrechtsmeier: I'll close this merge request and kindly ask you to resubmit this pull request on basis of the current master. THX a lot |
Closed
This was referenced Dec 7, 2012
Closed
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
ghost
mentioned this pull request
9 tasks
ghost
mentioned this pull request
bhawanaprasain
pushed a commit
to JankariTech/core
that referenced
this pull request
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a SSL proxy that handles multiple domains via host name
as prefix in the request URI (https://ssl-proxy.tld/domain.tld/).
As the SSL proxy is transparent for the web server the REQUEST_URI and
SCRIPT_NAME need manual adjustments. This patch replace the direct use
of this _SERVER variables with function calls and extend this functions
to detect the proxy and to add the needed prefix. Additionally it adds
a Sabre request backend with extends the Sabre_HTTP_Request to use the
same functions.
http://bugs.owncloud.org/thebuggenie/owncloud/issues/oc-890