Deduplicate and extract user/password extraction from alternative HTTP headers logic. #9735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💣 Test Failed. 💣 |
bantu
changed the title
|
@owncloud-bot Retest this please. |
|
The inspection completed: 6 new issues, 2 updated code elements |
|
🚀 Test Passed. 🚀 |
|
👍 - Great. We can drop the |
LukasReschke
added a commit
that referenced
this pull request
Jul 19, 2014
This `strip_tags` seems to be completely unneeded and will cause problems with passwords containing stripped characters. (e.g. `<` or `>`) Needs #9735 to be merged first.
|
@PVince81 @DeepDiver1975 @icewind1991 @nickvergessen Please review |
|
I suggest to close this in favor of #9738 where it's used ? |
yes |
LukasReschke
added a commit
that referenced
this pull request
Jul 22, 2014
This `strip_tags` seems to be completely unneeded and will cause problems with passwords containing stripped characters. (e.g. `<` or `>`) Needs #9735 to be merged first.
LukasReschke
added a commit
that referenced
this pull request
Jul 22, 2014
This `strip_tags` seems to be completely unneeded and will cause problems with passwords containing stripped characters. (e.g. `<` or `>`) Needs #9735 to be merged first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous solution was not good because it is hard to see that there is no difference between the two blocks. This is now clear because we are iterating over a list of variable names. The variable name for the list can be kept short because the logic was also extracted into its own function.
Refs #9310