-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production deployment based on Hetzner Cloud #891
Conversation
modules/ROOT/pages/depl-examples/ubuntu-compose/ubuntu-compose-hetzner.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/depl-examples/ubuntu-compose/ubuntu-compose-hetzner.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/depl-examples/ubuntu-compose/ubuntu-compose-hetzner.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/depl-examples/ubuntu-compose/shared-setup.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/depl-examples/ubuntu-compose/shared-setup.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/depl-examples/ubuntu-compose/shared-setup.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/depl-examples/ubuntu-compose/shared-setup.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/depl-examples/ubuntu-compose/shared-setup.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/depl-examples/ubuntu-compose/shared-setup.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/partials/depl-examples/ubuntu-compose/shared-setup.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text LGTM and reasonable. I will let others review to approve the whole content/purpose etc.
lets merge and improve on request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General request: I'd prefer to have the text more concise (less is more - no one says thank you for a thick manual as this smells like work :) )
a781108
to
b5b3e31
Compare
Co-authored-by: Phil Davis <phil@jankaritech.com>
References: #884 (Production deployment based on docker compose)
Fixes: #839, #838, #807, #803, #775, #774
Currently visible on staging.
Language review necessary.
Note that this PR has been tested including creating a server + deployment + LE certificates + access 😄
We need to wait to merge until 5.0.6 is out AND that prod latest on
docker.hub
points to 5.0.6Backport to 5.0
Note that this PR MUST be merged before #884.
When done, #884 must be rebased and adapted to use the common text component which eases maintenance a lot !