Skip to content

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 3, 2024

Add a clean step when building the bundle.
This deletes existing contens of the build and public folders.

When creating a bundle locally now, we will get the same result as when building via the CI. Before, when not cleaning the public folder, you will get a ui-bundle.zip file with content while on CI where there was no public folder and the zip file contained crap.

With this PR, we can now identify dependency updates breaking the system when doing local tests.

@DeepDiver1975 DeepDiver1975 requested a review from mmattel April 3, 2024 08:53
Copy link
Collaborator

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, runs fine, many thanks 👍

@mmattel mmattel merged commit b577a03 into master Apr 3, 2024
@delete-merged-branch delete-merged-branch bot deleted the chore/clean-build branch April 3, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants