Relocate static files from the docs repo to the UI #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmattel
force-pushed
the
migrate_supplemental_from_docs_here
branch
from
501d665 to
70c6252
Compare
LukasHirt
reviewed
Oct 13, 2025
| if (!fs.existsSync(dest)) { | ||
| mkdirp.sync(dest) | ||
| } | ||
| if (!fs.existsSync(`${src}/static`)) { |
There was a problem hiding this comment.
I would say this one shouldn't be created in the build process.
- if the directory is missing, it might symbolise something broken so actually failing the process because of that would make sense
- providing source directories feels more like maintainers responsibility than the build script itself
The dest directory is handled before that as that is the specific output of the build script so in that case I would say it's correct to force the script to take care of that.
There was a problem hiding this comment.
No, the proposed code change is correct, the static folder is OPTIONAL (no kidding). I will explain this tomorrow in zoom 😃
LukasHirt
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: owncloud/docs#5046 (Remove overlay files (migrate to docs-ui) )
This PR is two fold:
This makes these files available to all builds as they are part of the bundle zip file now.
It is VERY important that this PR is merged FIRST than the docs PR. The latter removes the "supplemental" definition from the docs playbook (site.yml) and its related files.
Things stay the same contentwise, it is just relocating files and functionality.
Tested via a local build using the docs branch that removes the supplemental definition - works.