Fix errors and omissions in the developer tutorial #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a series of mistakes in the code samples, along with some of the text, that could lead developers to make unnecessary and frustrating mistakes.
|
@PVince81 mind to review so we can proceed ? |
PVince81
reviewed
Jan 29, 2019
modules/developer_manual/pages/app/tutorial/development_environment.adoc
Show resolved
Hide resolved
PVince81
reviewed
Jan 29, 2019
modules/developer_manual/pages/app/tutorial/development_environment.adoc
Outdated
Show resolved
Hide resolved
|
Feedback has been implemented. |
This is based on advice from @PVince81
settermjd
force-pushed
the
update-developer-tutorial
branch
from
98db3c3
to
e7bd37a
Compare
settermjd
added a commit
that referenced
this pull request
Mar 8, 2019
* Fix errors and omissions in the developer tutorial * Correct list of directories and min/max version documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a series of mistakes in the example code, along with some of the text, that could lead developers to make unnecessary and frustrating mistakes.