encryption PHP unit tests fail

[phil-davis]

https://drone.owncloud.com/owncloud/encryption/2223/4/4

7.4: Pulling from owncloudci/php
Digest: sha256:ccda771b8c1582336b853aceb9959e842f125d6d51a65f5ecde50a070675aaed
Status: Image is up to date for owncloudci/php:7.4
+ make test-php-unit-dbg
phpdbg -qrr -d memory_limit=4096M -d zend.enable_gc=0 "../../lib/composer/bin/phpunit" --configuration ./phpunit.xml --testsuite unit
PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

Runtime:       PHPDBG 7.4.27
Configuration: ./phpunit.xml

FFF............................................................  63 / 259 ( 24%)
............................................................... 126 / 259 ( 48%)
............................................................... 189 / 259 ( 72%)
............................................................... 252 / 259 ( 97%)
.......                                                         259 / 259 (100%)

Time: 00:11.840, Memory: 554.42 MB

There were 3 failures:

1) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionIsNotZero
Failed asserting that 'Verifying the content of file /test_enc_version_affected_user1/files/hello.txt\n
The file /test_enc_version_affected_user1/files/hello.txt is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/ownCloud Manual.pdf\n
The file /test_enc_version_affected_user1/files/ownCloud Manual.pdf is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/world.txt\n
The file /test_enc_version_affected_user1/files/world.txt is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Lake-Constance.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Lake-Constance.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Portugal.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Portugal.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Teotihuacan.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Teotihuacan.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Documents/Example.odt\n
The file /test_enc_version_affected_user1/files/Documents/Example.odt is: OK\n
' contains "Verifying the content of file /test_enc_version_affected_user1/files/hello.txt
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt
Increment the encrypted version to 1
The file /test_enc_version_affected_user1/files/hello.txt is: OK
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 1".

/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:136

2) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionLessThanOriginalValue
Failed asserting that 'Verifying the content of file /test_enc_version_affected_user1/files/foo.txt\n
The file /test_enc_version_affected_user1/files/foo.txt is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/hello.txt\n
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt\n
Decrement the encrypted version to 1\n
Increment the encrypted version to 3\n
Increment the encrypted version to 4\n
Increment the encrypted version to 5\n
The file /test_enc_version_affected_user1/files/hello.txt is: OK\n
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 5\n
Verifying the content of file /test_enc_version_affected_user1/files/ownCloud Manual.pdf\n
The file /test_enc_version_affected_user1/files/ownCloud Manual.pdf is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/world.txt\n
Attempting to fix the path: /test_enc_version_affected_user1/files/world.txt\n
Increment the encrypted version to 2\n
Increment the encrypted version to 3\n
Increment the encrypted version to 4\n
Increment the encrypted version to 5\n
The file /test_enc_version_affected_user1/files/world.txt is: OK\n
Fixed the file: /test_enc_version_affected_user1/files/world.txt with version 5\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Lake-Constance.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Lake-Constance.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Portugal.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Portugal.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Teotihuacan.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Teotihuacan.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Documents/Example.odt\n
The file /test_enc_version_affected_user1/files/Documents/Example.odt is: OK\n
' contains "Verifying the content of file /test_enc_version_affected_user1/files/hello.txt
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt
Decrement the encrypted version to 1
Increment the encrypted version to 3
Increment the encrypted version to 4
Increment the encrypted version to 5
Increment the encrypted version to 6
The file /test_enc_version_affected_user1/files/hello.txt is: OK
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 6".

/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:194

3) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionGreaterThanOriginalValue
Failed asserting that 'Verifying the content of file /test_enc_version_affected_user1/files/foo.txt\n
The file /test_enc_version_affected_user1/files/foo.txt is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/hello.txt\n
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt\n
Decrement the encrypted version to 14\n
Decrement the encrypted version to 13\n
Decrement the encrypted version to 12\n
Decrement the encrypted version to 11\n
Decrement the encrypted version to 10\n
Decrement the encrypted version to 9\n
Decrement the encrypted version to 8\n
The file /test_enc_version_affected_user1/files/hello.txt is: OK\n
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 8\n
Verifying the content of file /test_enc_version_affected_user1/files/ownCloud Manual.pdf\n
The file /test_enc_version_affected_user1/files/ownCloud Manual.pdf is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/world.txt\n
Attempting to fix the path: /test_enc_version_affected_user1/files/world.txt\n
Decrement the encrypted version to 14\n
Decrement the encrypted version to 13\n
Decrement the encrypted version to 12\n
Decrement the encrypted version to 11\n
Decrement the encrypted version to 10\n
Decrement the encrypted version to 9\n
The file /test_enc_version_affected_user1/files/world.txt is: OK\n
Fixed the file: /test_enc_version_affected_user1/files/world.txt with version 9\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Lake-Constance.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Lake-Constance.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Portugal.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Portugal.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Photos/Teotihuacan.jpg\n
The file /test_enc_version_affected_user1/files/Photos/Teotihuacan.jpg is: OK\n
Verifying the content of file /test_enc_version_affected_user1/files/Documents/Example.odt\n
The file /test_enc_version_affected_user1/files/Documents/Example.odt is: OK\n
' contains "Verifying the content of file /test_enc_version_affected_user1/files/hello.txt
Attempting to fix the path: /test_enc_version_affected_user1/files/hello.txt
Decrement the encrypted version to 14
Decrement the encrypted version to 13
Decrement the encrypted version to 12
Decrement the encrypted version to 11
Decrement the encrypted version to 10
Decrement the encrypted version to 9
The file /test_enc_version_affected_user1/files/hello.txt is: OK
Fixed the file: /test_enc_version_affected_user1/files/hello.txt with version 9".

/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:260

FAILURES!
Tests: 259, Assertions: 742, Failures: 3.

This started happening on the nightly CI from 2021-12-22 AM. I suspect that core release-10.9.0 was merged back on 2021-12-21, and some change in core master is causing this problem.

[phil-davis]

Note: https://github.com/owncloud/ransomware_protection/issues/276 might be related. That is some acceptance tests failing in ransomware_protection when running with encryption.

[phil-davis]

Also acceptance test fails like: https://drone.owncloud.com/owncloud/encryption/2223/15/11

  Scenario: User overwrites a shared file with legacy encoding after encoding is switched                                      # /var/www/owncloud/testrunner/apps/encryption/tests/acceptance/features/apiEncryption/encoding.feature:82
    Given the administrator has added system config key "encryption.use_legacy_encoding" with value "false" and type "boolean" # OccContext::theAdministratorHasAddedSystemConfigKeyWithValueUsingTheOccCommand()
    And user "Alice" has uploaded file with content "some data" to "/textfile1.txt"                                            # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Brian" has been created with default attributes and without skeleton files                                       # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has shared file "textfile1.txt" with user "Brian"                                                         # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And the administrator has added system config key "encryption.use_legacy_encoding" with value "true" and type "boolean"    # OccContext::theAdministratorHasAddedSystemConfigKeyWithValueUsingTheOccCommand()
    Then the content of file "/textfile1.txt" for user "Brian" should be "some data"                                           # FeatureContext::contentOfFileForUserShouldBe()
    When user "Brian" uploads file with content "some new data" to "/textfile1.txt" using the WebDAV API                       # FeatureContext::userUploadsAFileWithContentTo()
    Then the content of file "/textfile1.txt" for user "Alice" should be "some new data"                                       # FeatureContext::contentOfFileForUserShouldBe()
      The downloaded content was expected to be 'some new data', but actually is '�	��wx�w���{'. HTTP status was 200
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'some new data'
      +Binary String: 0xed09addd0c77789c7785ad157b
    And the content of file "/textfile1.txt" for user "Brian" should be "some new data" 

runsh: Total unexpected failed scenarios throughout the test run:
apiEncryption/encoding.feature:82
apiEncryption/encoding.feature:93

[phil-davis]

There are lots of acceptance test pipelines that fail (see any recent nightly CI run). The common problem seems to be when a share receiver overwrites a received shared file.

[phil-davis]

And similar in user_ldap pipelines with encryption, for example:
https://drone.owncloud.com/owncloud/user_ldap/3670/126/20

    When user "Carol" uploads file "filesForUpload/file_to_overwrite.txt" to "/textfile0.txt" using the WebDAV API # FeatureContext::userUploadsAFileTo()
    Then the content of file "/common/sub/textfile0.txt" for user "Carol" should be "BLABLABLA" plus end-of-line   # FeatureContext::contentOfFileForUserShouldBePlusEndOfLine()
      The downloaded content was expected to be 'BLABLABLA
      ', but actually is '�A��'. HTTP status was 200
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'BLABLABLA\n
      -'
      +'�A��'

[individual-it]

reopening because tests still fail https://drone.owncloud.com/owncloud/encryption/2232/
I will try to reproduce locally

[JammingBen]

It's all good, see https://github.com/owncloud/enterprise/issues/4933#issuecomment-1002556244 -> latest doesn't include the fix yet, only master does.

[individual-it]

you are right, let's run the tests with 10.9.1RC1 for now #316