Skip to content

Conversation

jancborchardt
Copy link
Member

Currently it looked a bit strange on mobile with the wonky non-hanging punctuation. Now it’s nice here as well.

The only drawback is that the lowest heading you can distinguish is a h4 (cause the other # characters do not show) but the styling for h4/h5/h6 is the same anyway so seriously on mobile we don’t need to differentiate that.

Please review @owncloud/designers @Henni @LukasReschke @BernhardPosselt

@jancborchardt
Copy link
Member Author

@tchncs in case you want to review this as well. :) You are also very welcome in our IRC channel #owncloud-design (on freenode). And we appreciate any design contributions!

@Henni
Copy link
Contributor

Henni commented Dec 8, 2015

I distinguished between desktop and mobile because of this:
image

@jancborchardt
Copy link
Member Author

@Henni I know. As I said above:

The only drawback is that the lowest heading you can distinguish is a h4 (cause the other # characters do not show) but the styling for h4/h5/h6 is the same anyway so seriously on mobile we don’t need to differentiate that.

So I don’t think that’s worth the tradeoff.

Also, the size will be fixed by #181 leading to more hash signs being visible on the left.

@Henni
Copy link
Contributor

Henni commented Dec 8, 2015

@jancborchardt please rebase

@jancborchardt
Copy link
Member Author

@Henni done :)

@verymilan
Copy link

You are also very welcome in our IRC channel

Oh, i just saw my latest mails, sorry, should change my mail on github to see mentions earlier.^^
Im little busy this time but might join your channel soon :)
I dont have that much experience but will try to be helpful.

@jancborchardt
Copy link
Member Author

@tchncs don’t worry, any contribution is welcome! Everyone started small at some point – that’s why we work on this together and help each other if there’s any questions. :)

@Henni
Copy link
Contributor

Henni commented Dec 10, 2015

This is how it looks like on iPhone 5 (emulated in Chrome). I'm not sure if I'm happy with how h4 and higher are handled.
image

@jancborchardt
Copy link
Member Author

I gotta say I’m ok with it. We could make the hashes for the h5 and h6 even smaller to signify it? But two heading sizes which are rarely ever used shouldn’t impact the overall experience.

jancborchardt added a commit that referenced this pull request Mar 7, 2016
use hanging punctuation on mobile as well
@jancborchardt jancborchardt merged commit e6601fb into master Mar 7, 2016
@jancborchardt jancborchardt deleted the mobile-styles branch March 7, 2016 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants