migrate the notes app to owncloud 8 #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return Folder | ||
| */ | ||
| private function getFolderForUser ($userId) { | ||
| $path = '/' . $userId . '/files/notes'; |
There was a problem hiding this comment.
This was 'files/Notes' before
There was a problem hiding this comment.
Yes, but the folder that went in was already in the /$userId/
There was a problem hiding this comment.
I mean the folder used to be with an upper case 'N'
|
@LukasReschke unit tests + migration done :) |
| @@ -140,38 +110,98 @@ public function update($id, $content){ | |||
| $title = str_replace(array('/', '\\'), '', $title); | |||
There was a problem hiding this comment.
I wonder if we can get rid of this by using a view on Notes
There was a problem hiding this comment.
Should already be a view I think
LukasReschke
added a commit
that referenced
this pull request
Feb 11, 2015
migrate the notes app to owncloud 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: