Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Reva ocis storage #466

Merged
merged 39 commits into from
Sep 11, 2020
Merged

Reva ocis storage #466

merged 39 commits into from
Sep 11, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Sep 10, 2020

As discussed, pointing at cs3org/reva#559 for now.
On top of #461

Raised owncloud/product#221 to address the tests that got disabled.

To switch to ocis storage, use:

REVA_STORAGE_HOME_DRIVER=ocis REVA_STORAGE_HOME_DATA_DRIVER=ocis REVA_STORAGE_OC_DRIVER=ocis REVA_STORAGE_OC_DATA_DRIVER=ocis OCIS_LOG_LEVEL=debug go run cmd/ocis/main.go server

@individual-it FYI, could use this branch as a base for putting the tests into Drone

@PVince81
Copy link
Contributor Author

I've pushed a fix for go.mod replace, should compile now

@PVince81
Copy link
Contributor Author

rebased since #461 was merged

@individual-it
Copy link
Member

tests on ocis storage now kick off in CI but mostly fail because of uploading/creating folder issues
2020-09-10T16:03:19Z ERR srv/app/pkg/mod/github.com/butonic/reva@v0.0.0-20200910140954-a6079f23695f/internal/grpc/services/storageprovider/storageprovider.go:354 > error creating home error="symlink ../24d77122-402b-4e5a-90de-348dce02149b /srv/app/tmp/ocis/root/nodes/root/Alice: no such file or directory" pkg=rgrpc service=reva traceid=412e3c957f642690aa3676aac11b4681
I've skipped all failing tests for now

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 11, 2020

remaining failures, getting closer:

apiVersions/fileVersions.feature:61 apiVersions/fileVersions.feature:69

apiWebdavProperties1/setFileProperties.feature:20
apiWebdavProperties1/setFileProperties.feature:21
apiWebdavProperties1/setFileProperties.feature:45
apiWebdavProperties1/setFileProperties.feature:46
apiWebdavProperties1/setFileProperties.feature:76
apiWebdavProperties1/setFileProperties.feature:77
apiWebdavProperties1/setFileProperties.feature:80
apiWebdavProperties2/getFileProperties.feature:58
apiWebdavProperties2/getFileProperties.feature:62
apiWebdavProperties2/getFileProperties.feature:65
apiWebdavProperties2/getFileProperties.feature:69
apiWebdavUpload2/uploadFileUsingNewChunking.feature:74

Comment on lines 208 to 209
apiShareManagementBasic/deleteShare.feature:36
apiShareManagementBasic/deleteShare.feature:37
Copy link
Contributor

@phil-davis phil-davis Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other apiShareManagementBasic/*.feature should also be deleted. They do not get reported as "unexpected pass" because that suite does not even exist any more. (rebasing this PR some day should help to find this sort of stuff)

@individual-it
Copy link
Member

etags in PROPFIND are not quoted, that will make a lot of tests fail because etag are checked when checking if a file/folder exists
image

@individual-it
Copy link
Member

rebased to solve conflicts

@PVince81
Copy link
Contributor Author

4 more to go:

apiWebdavProperties2/getFileProperties.feature:58
apiWebdavProperties2/getFileProperties.feature:62
apiWebdavProperties2/getFileProperties.feature:65
apiWebdavProperties2/getFileProperties.feature:69

but first I'll update based on the reva master as the branch got merged

Brings in the new OCIS storage driver
@phil-davis
Copy link
Contributor

phil-davis commented Sep 11, 2020

4 more to go

@PVince81 yes, add them to tests/acceptance/expected-failures-on-OCIS-storage.txt - they are examples for propfind of "more ordinary" folder names. the "ocis" storage is not even handling those correctly. The "oc" storage does handle those OK. Both storages have trouble with the other examples that have more strange folder names - the other example lines from 58 to 71.

All these failing scenarios eventually have to be looked into and fixed. But, hopefully, fixing some common issue will make a lot of them suddenly pass.

@phil-davis phil-davis self-requested a review September 11, 2020 13:24
Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jeeez that is still a long list of expected failures ...

@phil-davis
Copy link
Contributor

jeeez that is still a long list of expected failures

But many of them will turn out to be due to small bugs that cause common trouble for many test scenarios.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes/enhancements LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants