Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Href in trashbin PROPFIND response is wrong #1120

Closed
individual-it opened this issue Dec 17, 2020 · 1 comment · Fixed by cs3org/reva#1425
Closed

Href in trashbin PROPFIND response is wrong #1120

individual-it opened this issue Dec 17, 2020 · 1 comment · Fixed by cs3org/reva#1425
Labels
Category:Defect Existing functionality is not working as expected Type:Bug

Comments

@individual-it
Copy link
Member

  1. as einstein upload a file: curl -k 'https://localhost:9200/remote.php/webdav/file.txt' -XPUT -ueinstein:relativity -d"123"

  2. as einstein delete the file curl -k 'https://localhost:9200/remote.php/webdav/file.txt' -XDELETE -ueinstein:relativity

  3. check the content of the trashbin: curl -k 'https://localhost:9200/remote.php/dav/trash-bin/einstein' -X PROPFIND -ueinstein:relativity | xmllint --format -
    => the href is shown as: /remote.php/dav/trash-bin/4c510ada-c86b-4815-8820-42cdf82c3d51:f46e6676-56e7-478e-88f9-6d4139d3ef23

  4. trying to restore (MOVE) this file will fail with HTTP 405 curl -k 'https://localhost:9200/remote.php/dav/trash-bin/4c510ada-c86b-4815-8820-42cdf82c3d51:f46e6676-56e7-478e-88f9-6d4139d3ef23' -X MOVE -H'Destination: https://localhost:9200/remote.php/dav/files/einstein/textfile0.txt' -ueinstein:relativity -v
    the correct path is remote.php/dav/trash-bin/einstein/4c510ada-c86b-4815-8820-42cdf82c3d51:f46e6676-56e7-478e-88f9-6d4139d3ef23
    curl -k 'https://localhost:9200/remote.php/dav/trash-bin/einstein/4c510ada-c86b-4815-8820-42cdf82c3d51:f46e6676-56e7-478e-88f9-6d4139d3ef23' -X MOVE -H'Destination: https://localhost:9200/remote.php/dav/files/einstein/textfile0.txt' -ueinstein:relativity -v works

    Web uses the correct path and not the one that is given in href, so the restore works there
@individual-it individual-it changed the title for users that have been created by OCS, href in trashbin is wrong href in trashbin PROPFIND responst is wrong Dec 17, 2020
@individual-it individual-it changed the title href in trashbin PROPFIND responst is wrong href in trashbin PROPFIND response is wrong Dec 17, 2020
@settings settings bot removed the bug label Jan 12, 2021
@refs refs added the Category:Defect Existing functionality is not working as expected label Jan 13, 2021
@refs refs changed the title href in trashbin PROPFIND response is wrong Href in trashbin PROPFIND response is wrong Jan 13, 2021
@butonic butonic mentioned this issue Jan 28, 2021
Merged
@settings settings bot removed the p3-medium label Apr 7, 2021
@C0rby
Copy link
Contributor

C0rby commented May 11, 2021

This should also be fixed.

@C0rby C0rby closed this as completed May 11, 2021
@jasson99 jasson99 mentioned this issue Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category:Defect Existing functionality is not working as expected Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align href url encoding with oc10 butonic/reva
3 participants
@individual-it @C0rby @refs