Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][tests-only]Forward-port run e2e tests on keycloak #10481

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Feb 14, 2024

Description

This PR runs tests on keycloak in CI. For now, tests under journey are running on keycloak.
Journey folder contains multiple user login and logout, sharing.
Do you think we should run other feature files or is this enough?
cc @ScharfViktor

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Feb 14, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@amrita-shrestha amrita-shrestha changed the title [WIP]Run e2e tests on keycloak [WIP][full-ci][tests-only]Run e2e tests on keycloak Feb 15, 2024
@amrita-shrestha amrita-shrestha force-pushed the run-tests-on-keycloak branch 14 times, most recently from 14b513e to 208a6e6 Compare February 20, 2024 03:55
@amrita-shrestha amrita-shrestha force-pushed the run-tests-on-keycloak branch 4 times, most recently from c2a9b1c to d1fa8eb Compare February 23, 2024 06:13
@amrita-shrestha amrita-shrestha marked this pull request as ready for review February 23, 2024 06:33
@amrita-shrestha amrita-shrestha changed the title [WIP][full-ci][tests-only]Run e2e tests on keycloak [full-ci][tests-only]Run e2e tests on keycloak Feb 23, 2024
.drone.star Show resolved Hide resolved
.drone.star Outdated Show resolved Hide resolved
"trigger": {
"ref": [
"refs/heads/master",
"refs/heads/stable-*",
Copy link
Member

@saw-jan saw-jan Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we target this PR to stable-8.0 first? I would recommend to do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move e2e-test-on-keycloak in the pipeline list for convenience?

Screenshot 2024-02-23 at 15 33 53

.drone.star Outdated Show resolved Hide resolved
.drone.star Outdated
"KEYCLOAK_HOST": "keycloak:8443",
},
"commands": [
"pnpm test:e2e:cucumber tests/e2e/cucumber/features/smoke/admin-settings/{users.feature:20,spaces.feature}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor please confirm if these are the only features we want to run or not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to include /journeys/kindergarten.feature
and I couldn't find users.feature:20 in the CI https://drone.owncloud.com/owncloud/web/42946/16/15

@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented Mar 4, 2024

blocked due to ocis login fails after role assigned from keycloak reported issue owncloud/ocis#8567

.drone.star Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the run-tests-on-keycloak branch 8 times, most recently from 3387633 to 1de69eb Compare March 11, 2024 05:53
@amrita-shrestha amrita-shrestha changed the title [full-ci][tests-only]Run e2e tests on keycloak [full-ci][tests-only]Forward-port run e2e tests on keycloak Mar 11, 2024
update ocis version and go version
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@amrita-shrestha amrita-shrestha merged commit 56bb6f7 into master Mar 12, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the run-tests-on-keycloak branch March 12, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] run e2e tests with external idp (keycloak) in CI
3 participants