Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] fix test expiration date #11051

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jun 17, 2024

I'm not very happy with my current solution, but it can unlock you @kulmann quickly.

this is what happens:

Screen.Recording.2024-06-17.at.12.20.56.mov

after setting timeout this behavior doesn't exist

Copy link

update-docs bot commented Jun 17, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann
Copy link
Member

kulmann commented Jun 17, 2024

Can you reproduce this glitch in the ui or is it only happening in playwright? 😨

@ScharfViktor
Copy link
Contributor Author

Can you reproduce this glitch in the ui or is it only happening in playwright? 😨

no, I couldn't reproduce it in ui

@ScharfViktor ScharfViktor merged commit 30fe442 into master Jun 17, 2024
2 checks passed
@phil-davis phil-davis deleted the fixTestExpirationDate branch June 17, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants