Shared with others list #1702

LukasHirt · 2019-08-06T15:23:32Z

Description

Created SharedFilesList component. Moved most of file list related functionality into mixins so we can reuse it in different lists. At the moment this list doesn't contain any actions thus checkboxes and star were removed as well and file name got class uk-disabled to prevent any hover/focus on it and to allow selecting of the row by clicking on it.

Related Issue

Refs Collaborators tweaks after review #1186

How Has This Been Tested?

test environment: Manually

Share file with other user
Share file that has been shared with me with can share permission with some other user

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

DeepDiver1975 · 2019-08-06T15:43:42Z

apps/files/src/default.js

@@ -56,6 +56,14 @@ const navItems = [
      path: `/${appInfo.id}/favorites`
    }
  },
+  {
+    name: 'Shared with others',


we need to find a way to get this translated ....

I guess we could translate it inside the menu component in computed properties but doesn't really seem like a nice solution.

DeepDiver1975 · 2019-08-06T15:44:59Z

apps/files/src/store/actions.js

+  loadFolderSharedFromMe (context, { client, $gettext }) {
+    context.commit('UPDATE_FOLDER_LOADING', true)
+
+    client.requests.ocs({


are we missing an api method in the sdk here?

I found mentions of shared_with_me in the shares there but no way how to load shared with others. (tried to use the getShares function, it's possible I overlooked something or did something wrong though)

DeepDiver1975 · 2019-08-12T12:51:29Z

Is it possible to add a column with the recipients?

e.g. for user shares you have this information

for link shares at least a chain icon can be displayed ...

LukasHirt · 2019-08-12T13:20:49Z

Is it possible to add a column with the recipients?

@DeepDiver1975 With the current implementation we could display only one recipient per item... I'm filtering the response to remove all duplicate files to save a little bit of the performance and not build the same file e. g. 5 times.

DeepDiver1975 · 2019-08-12T13:29:06Z

With the current implementation we could display only one recipient per item... I'm filtering the response to remove all duplicate files to save a little bit of the performance and not build the same file e. g. 5 times.

Understood - oc10 is doing the same afaik

DeepDiver1975 · 2019-08-12T13:29:18Z

and there is a conflict - please resolve - THX

LukasHirt · 2019-08-12T13:35:45Z

Understood - oc10 is doing the same afaik

I added at least that one user. We can try to figure this out later IMHO 🤷‍♂

and there is a conflict - please resolve - THX

Rebased 😉

DeepDiver1975 · 2019-08-12T14:13:30Z

@LukasHirt whats wrong with the tests? mind having a look? THX

LukasHirt · 2019-08-12T15:09:03Z

Should be green now. Let's see

LukasHirt · 2019-08-12T15:31:49Z

Damn. Still not 🤬

Build only unique files Added original file id Added shared with Fixed for cycle for sidebars Hide files list on trashbin page

LukasHirt · 2019-08-12T18:05:16Z

@DeepDiver1975 Green 🙌

LukasHirt added Category:Enhancement Add new functionality Status:In-Progress labels Aug 6, 2019

LukasHirt self-assigned this Aug 6, 2019

LukasHirt changed the title ~~Created shared from me list [WIP]~~ Shared with others list [WIP] Aug 6, 2019

DeepDiver1975 reviewed Aug 6, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

LukasHirt force-pushed the feature/shared-from-me-list branch from 838746a to a53ecda Compare August 12, 2019 09:21

LukasHirt changed the title ~~Shared with others list [WIP]~~ Shared with others list Aug 12, 2019

LukasHirt added Status:Needs-Review Needs review from a maintainer and removed Status:In-Progress labels Aug 12, 2019

LukasHirt requested a review from DeepDiver1975 August 12, 2019 09:25

This comment has been minimized.

Sign in to view

LukasHirt marked this pull request as ready for review August 12, 2019 11:20

LukasHirt force-pushed the feature/shared-from-me-list branch from a53ecda to 8f61302 Compare August 12, 2019 13:34

This comment has been minimized.

Sign in to view

LukasHirt force-pushed the feature/shared-from-me-list branch from 8f61302 to d3bade1 Compare August 12, 2019 15:07

This comment has been minimized.

Sign in to view

Created shared from me list

672e7db

Build only unique files Added original file id Added shared with Fixed for cycle for sidebars Hide files list on trashbin page

LukasHirt force-pushed the feature/shared-from-me-list branch from d3bade1 to 672e7db Compare August 12, 2019 15:45

DeepDiver1975 approved these changes Aug 12, 2019

View reviewed changes

DeepDiver1975 merged commit 6b1e77b into master Aug 12, 2019

delete-merged-branch bot deleted the feature/shared-from-me-list branch August 12, 2019 19:19

dpakach mentioned this pull request Sep 16, 2019

Add acceptance tests for shared with me and shared with others page. #1983

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shared with others list #1702

Shared with others list #1702

LukasHirt commented Aug 6, 2019 •

edited

Loading

DeepDiver1975 Aug 6, 2019

LukasHirt Aug 7, 2019

DeepDiver1975 Aug 6, 2019

LukasHirt Aug 7, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

DeepDiver1975 commented Aug 12, 2019

LukasHirt commented Aug 12, 2019 •

edited

Loading

DeepDiver1975 commented Aug 12, 2019

DeepDiver1975 commented Aug 12, 2019

LukasHirt commented Aug 12, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

DeepDiver1975 commented Aug 12, 2019

LukasHirt commented Aug 12, 2019

This comment has been minimized.

This comment has been minimized.

LukasHirt commented Aug 12, 2019

This comment has been minimized.

LukasHirt commented Aug 12, 2019

Shared with others list #1702

Shared with others list #1702

Conversation

LukasHirt commented Aug 6, 2019 • edited Loading

Description

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

DeepDiver1975 Aug 6, 2019

Choose a reason for hiding this comment

LukasHirt Aug 7, 2019

Choose a reason for hiding this comment

DeepDiver1975 Aug 6, 2019

Choose a reason for hiding this comment

LukasHirt Aug 7, 2019

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

DeepDiver1975 commented Aug 12, 2019

LukasHirt commented Aug 12, 2019 • edited Loading

DeepDiver1975 commented Aug 12, 2019

DeepDiver1975 commented Aug 12, 2019

LukasHirt commented Aug 12, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

DeepDiver1975 commented Aug 12, 2019

LukasHirt commented Aug 12, 2019

This comment has been minimized.

This comment has been minimized.

LukasHirt commented Aug 12, 2019

This comment has been minimized.

LukasHirt commented Aug 12, 2019

LukasHirt commented Aug 6, 2019 •

edited

Loading

LukasHirt commented Aug 12, 2019 •

edited

Loading