Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger collaborator edit only after change #1813

Merged

Conversation

LukasHirt
Copy link
Collaborator

Description

Check if the new selected role is not the same as original role and prevent trigger of edit if it is.

Related Issue

How Has This Been Tested?

  • test environment: Manually
  1. Select same role for collaborator
  2. Select different role for collaborator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Aug 16, 2019
@LukasHirt LukasHirt self-assigned this Aug 16, 2019
@DeepDiver1975 DeepDiver1975 merged commit 541781e into master Aug 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/trigger-collaborator-edit-only-after-change branch August 22, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants