Display indirect outgoing shares in collaborators panel #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
parent PR was rebased #2918 still waiting for it to be merged first |
kulmann
approved these changes
Jan 29, 2020
Make the gathering of the different collaborator information more readable. Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
- Move sort and filter functions to separate methods - Added method to retrieve outgoing indirect collaborators from sharesTree Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
- separate list of collaborators into three lists for owner (including resharers), direct shares and indirect shares. - as the modifiable property now is fixed for each of the three lists, it is now a property of the collaborator component. Co-authored-by: Vincent Petry <pvince81@owncloud.com>
PVince81
force-pushed
the
share-indirect-outgoing-shares
branch
from
c467030
to
c3b0d9c
Compare
|
now that #2918 is merged, rebased again |
15 tasks
Enabled tests for indirect outgoing collaborator shares. Added changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The collaborators panel now has an additional section that displays the list of collaborators from outgoing shares that exist via one of the parent resources.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: